Bug 206925 - [GTK] Extra packages needed to successfully run API tests (cups-daemon and fonts-liberation)
Summary: [GTK] Extra packages needed to successfully run API tests (cups-daemon and fo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-29 04:26 PST by Carlos Alberto Lopez Perez
Modified: 2020-01-29 06:14 PST (History)
12 users (show)

See Also:


Attachments
Patch (3.19 KB, patch)
2020-01-29 04:41 PST, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2020-01-29 04:26:57 PST
While deploying the new EWS bots for GTK API tests ( bug 202361 ) I found the following tests where failing on those bots but not on the release bot:


Unexpected failures (2)
    /TestWebCore
        ComplexTextControllerTest.TotalWidthWithJustification
        ComplexTextControllerTest.InitialAdvanceInRTLNoOrigins

Unexpected timeouts (5)
    /WebKit2Gtk/TestPrinting
        /webkit/WebKitWebView/print
        /webkit/WebKitPrintOperation/close-after-print
        /webkit/WebKitPrintOperation/print-errors
        /webkit/WebKitPrintOperation/print
        /webkit/WebKitPrintOperation/custom-widget

Upon investigation, it turns out that:

* For API printing tests its needed to have installed cups-daemon (its not enough with libcups-dev, you need the daemon running as well)
* For ComplexTextControllerTest failures you need to have installed the package fonts-liberation.
  Liberation should be selected for Times. In other words, this sould be the output of this command: 
$ fc-match -v Times|grep file
	file: "/usr/share/fonts/truetype/liberation/LiberationSerif-Regular.ttf"(w)
Comment 1 Carlos Alberto Lopez Perez 2020-01-29 04:41:51 PST
Created attachment 389121 [details]
Patch
Comment 2 WebKit Commit Bot 2020-01-29 05:48:13 PST
Comment on attachment 389121 [details]
Patch

Clearing flags on attachment: 389121

Committed r255353: <https://trac.webkit.org/changeset/255353>
Comment 3 WebKit Commit Bot 2020-01-29 05:48:15 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-01-29 05:49:12 PST
<rdar://problem/58988842>
Comment 5 Philippe Normand 2020-01-29 06:14:26 PST
FTR this isn't an issue in the upcoming Flatpak SDK:

webkit-flatpak --command=bash
$ fc-match -v Times|grep file
file: "/usr/share/fonts/liberation-fonts/LiberationSerif-Regular.ttf"(w)