Bug 206919 - macCatalyst: Right clicking on a link follows it immediately
Summary: macCatalyst: Right clicking on a link follows it immediately
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-28 21:57 PST by Tim Horton
Modified: 2020-01-28 22:47 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.00 KB, patch)
2020-01-28 21:57 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (8.33 KB, patch)
2020-01-28 21:59 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-01-28 21:57:38 PST 
macCatalyst: Right clicking on a link follows it immediately
Comment 1 Tim Horton 2020-01-28 21:57:58 PST 
Created attachment 389105 [details]
Patch
Comment 2 Tim Horton 2020-01-28 21:58:00 PST 
<rdar://problem/58936679>
Comment 3 Tim Horton 2020-01-28 21:59:17 PST 
Created attachment 389106 [details]
Patch
Comment 4 Wenson Hsieh 2020-01-28 22:01:40 PST 
Comment on attachment 389106 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389106&action=review

> Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm:177
> +    _pressedButtonMask = WTF::nullopt;

Should we clear this out in -touchesCancelled:withEvent: as well?
Comment 5 Wenson Hsieh 2020-01-28 22:03:19 PST 
Comment on attachment 389106 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389106&action=review

>> Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm:177
>> +    _pressedButtonMask = WTF::nullopt;
> 
> Should we clear this out in -touchesCancelled:withEvent: as well?

Never mind, -touchesCancelled:withEvent: calls -touchesEnded:withEvent: anyways. 😅
Comment 6 WebKit Commit Bot 2020-01-28 22:46:58 PST 
Comment on attachment 389106 [details]
Patch

Clearing flags on attachment: 389106

Committed r255337: <https://trac.webkit.org/changeset/255337>
Comment 7 WebKit Commit Bot 2020-01-28 22:47:00 PST 
All reviewed patches have been landed.  Closing bug.