Bug 206913 - TestWebKitAPI: Conditionalize device orientation tests on ENABLE(DEVICE_ORIENTATION)
Summary: TestWebKitAPI: Conditionalize device orientation tests on ENABLE(DEVICE_ORIEN...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-28 15:56 PST by Jonathan Bedard
Modified: 2020-01-28 16:55 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.09 KB, patch)
2020-01-28 15:58 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (1.34 KB, patch)
2020-01-28 16:13 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-01-28 15:56:05 PST 
It doesn't make sense to attempt to run device orientation tests when on a platform that has DEVICE_ORIENTATION disabled.
Comment 1 Radar WebKit Bug Importer 2020-01-28 15:56:52 PST 
<rdar://problem/58973357>
Comment 2 Jonathan Bedard 2020-01-28 15:58:27 PST 
Created attachment 389082 [details]
Patch
Comment 3 Chris Dumez 2020-01-28 16:06:16 PST 
Comment on attachment 389082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389082&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:28
> +#if ENABLE(DEVICE_ORIENTATION) && PLATFORM(IOS_FAMILY)

Please update this comment at the end of the file as well:
#endif // PLATFORM(IOS_FAMILY)
Comment 4 Jonathan Bedard 2020-01-28 16:13:05 PST 
Created attachment 389084 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2020-01-28 16:55:28 PST 
Comment on attachment 389084 [details]
Patch for landing

Clearing flags on attachment: 389084

Committed r255328: <https://trac.webkit.org/changeset/255328>
Comment 6 WebKit Commit Bot 2020-01-28 16:55:30 PST 
All reviewed patches have been landed.  Closing bug.