Bug 206910 - [iOS][WK2] Drop process assertion logic for holding locked files
Summary: [iOS][WK2] Drop process assertion logic for holding locked files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 213194
Blocks:
  Show dependency treegraph
 
Reported: 2020-01-28 14:45 PST by Chris Dumez
Modified: 2020-06-15 15:41 PDT (History)
5 users (show)

See Also:


Attachments
Patch (22.83 KB, patch)
2020-01-28 14:53 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (24.07 KB, patch)
2020-01-28 15:03 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (25.55 KB, patch)
2020-01-28 15:19 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (25.10 KB, patch)
2020-04-28 09:32 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (25.39 KB, patch)
2020-04-28 09:38 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-01-28 14:45:43 PST
Drop process assertion logic for holding locked files as it is causing issues and should no longer be needed.
Comment 1 Chris Dumez 2020-01-28 14:53:32 PST
Created attachment 389068 [details]
Patch
Comment 2 Chris Dumez 2020-01-28 15:03:09 PST
Created attachment 389071 [details]
Patch
Comment 3 Chris Dumez 2020-01-28 15:19:13 PST
Created attachment 389074 [details]
Patch
Comment 4 Chris Dumez 2020-02-20 09:17:02 PST
Comment on attachment 389074 [details]
Patch

Will investigate iOS api test failures.
Comment 5 Sihui Liu 2020-02-20 09:53:47 PST
Comment on attachment 389074 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389074&action=review

> Source/WebKit/ChangeLog:22
> +           those processes will make sure to suspend their database threads to prevent any

I remember further database work would be stopped only when the suspension is imminent or there is no ongoing transaction. 
If the concept of imminent suspension is still there, we need to also set IsSuspensionImminent::Yes, or set ShouldForceStop::No in WebIDBServer::suspend.

A nice thing about having the logic is we don't force aborting ongoing transaction if we know a message of holding file lock has been sent.
Comment 6 Chris Dumez 2020-04-28 09:32:22 PDT
Created attachment 397845 [details]
Patch
Comment 7 Chris Dumez 2020-04-28 09:38:51 PDT
Created attachment 397846 [details]
Patch
Comment 8 EWS 2020-04-28 17:03:27 PDT
Committed r260856: <https://trac.webkit.org/changeset/260856>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397846 [details].
Comment 9 Radar WebKit Bug Importer 2020-04-28 17:10:45 PDT
<rdar://problem/62558526>
Comment 10 Alexey Proskuryakov 2020-06-15 15:41:06 PDT
Looks like this got reverted, but the bug is still RESOLVED/FIXED.