Bug 206907 - TestWebKitAPI: Conditionalize QuickLook tests on USE(QUICK_LOOK)
Summary: TestWebKitAPI: Conditionalize QuickLook tests on USE(QUICK_LOOK)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-28 14:33 PST by Jonathan Bedard
Modified: 2020-01-28 16:07 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.17 KB, patch)
2020-01-28 14:37 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (1.18 KB, patch)
2020-01-28 15:23 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-01-28 14:33:50 PST 
It doesn't make sense to attempt to run QuickLook tests when on a platform that isn't using QuickLook.
Comment 1 Radar WebKit Bug Importer 2020-01-28 14:34:15 PST 
<rdar://problem/58969924>
Comment 2 Jonathan Bedard 2020-01-28 14:37:07 PST 
Created attachment 389065 [details]
Patch
Comment 3 Alexey Proskuryakov 2020-01-28 14:46:55 PST 
Comment on attachment 389065 [details]
Patch

rs=me, please double-check that this macro actually leaves the code enabled for iOS.
Comment 4 Jonathan Bedard 2020-01-28 15:11:03 PST 
(In reply to Alexey Proskuryakov from comment #3)
> Comment on attachment 389065 [details]
> Patch
> 
> rs=me, please double-check that this macro actually leaves the code enabled
> for iOS.

For reference sake, USE(QUICK_LOOK) is currently defined like so:

#if PLATFORM(IOS)
#define USE_QUICK_LOOK 1
#endif
Comment 5 Jonathan Bedard 2020-01-28 15:23:20 PST 
Created attachment 389076 [details]
Patch for landing
Comment 6 Alexey Proskuryakov 2020-01-28 15:36:03 PST 
> For reference sake, USE(QUICK_LOOK) is currently defined like so:

What I asked to verify was whether the definition was included in this file.
Comment 7 WebKit Commit Bot 2020-01-28 16:06:32 PST 
Comment on attachment 389076 [details]
Patch for landing

Clearing flags on attachment: 389076

Committed r255320: <https://trac.webkit.org/changeset/255320>
Comment 8 WebKit Commit Bot 2020-01-28 16:06:33 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Jonathan Bedard 2020-01-28 16:07:07 PST 
(In reply to Alexey Proskuryakov from comment #3)
> Comment on attachment 389065 [details]
> Patch
> 
> rs=me, please double-check that this macro actually leaves the code enabled
> for iOS.

That would also be yes. config.h -> wtf/Platform.h -> wtf/PlatformUse.h