RESOLVED FIXED206907
TestWebKitAPI: Conditionalize QuickLook tests on USE(QUICK_LOOK) 
https://bugs.webkit.org/show_bug.cgi?id=206907
Summary TestWebKitAPI: Conditionalize QuickLook tests on USE(QUICK_LOOK)
Jonathan Bedard
Reported 2020-01-28 14:33:50 PST
It doesn't make sense to attempt to run QuickLook tests when on a platform that isn't using QuickLook.
Attachments
Patch (1.17 KB, patch)
2020-01-28 14:37 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.18 KB, patch)
2020-01-28 15:23 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-01-28 14:34:15 PST
<rdar://problem/58969924>
Jonathan Bedard
Comment 2 2020-01-28 14:37:07 PST
Created attachment 389065 [details] Patch
Alexey Proskuryakov
Comment 3 2020-01-28 14:46:55 PST
Comment on attachment 389065 [details] Patch rs=me, please double-check that this macro actually leaves the code enabled for iOS.
Jonathan Bedard
Comment 4 2020-01-28 15:11:03 PST
(In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 389065 [details] > Patch > > rs=me, please double-check that this macro actually leaves the code enabled > for iOS. For reference sake, USE(QUICK_LOOK) is currently defined like so: #if PLATFORM(IOS) #define USE_QUICK_LOOK 1 #endif
Jonathan Bedard
Comment 5 2020-01-28 15:23:20 PST
Created attachment 389076 [details] Patch for landing
Alexey Proskuryakov
Comment 6 2020-01-28 15:36:03 PST
> For reference sake, USE(QUICK_LOOK) is currently defined like so: What I asked to verify was whether the definition was included in this file.
WebKit Commit Bot
Comment 7 2020-01-28 16:06:32 PST
Comment on attachment 389076 [details] Patch for landing Clearing flags on attachment: 389076 Committed r255320: <https://trac.webkit.org/changeset/255320>
WebKit Commit Bot
Comment 8 2020-01-28 16:06:33 PST
All reviewed patches have been landed. Closing bug.
Jonathan Bedard
Comment 9 2020-01-28 16:07:07 PST
(In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 389065 [details] > Patch > > rs=me, please double-check that this macro actually leaves the code enabled > for iOS. That would also be yes. config.h -> wtf/Platform.h -> wtf/PlatformUse.h
Note You need to log in before you can comment on or make changes to this bug.