Bug 206863 – macCatalyst: Triple clicking to select a sentence results in an empty selection

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

macCatalyst: Triple clicking to select a sentence results in an empty selection

[Tim Horton]

Created attachment 388965 [details]
Patch

[Tim Horton]

<rdar://problem/58776993>

[Sam Weinig]

Can this be tested? I know there are no layout tests for macCatalyst yet, but what about an API test or something else?

[Tim Horton]

Created attachment 389070 [details]
Patch

[Tim Horton]

Created attachment 389072 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Wenson Hsieh]

Comment on attachment 389072 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389072&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:2492
> +void WebPageProxy::doAfterProcessingAllPendingMouseEvents(WTF::Function<void (void)>&& action)

Nit - I think we usually write this WTF::Function<void()>&& (i.e. no second void)

> Tools/TestWebKitAPI/Tests/WebKitCocoa/MacCatalystMouseSupport.mm:28
> +#if PLATFORM(MACCATALYST)

Is it possible to adjust this such that we'll run these tests in automation?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/MacCatalystMouseSupport.mm:131
> +    [gesture _hoverEntered:touchSet.get() withEvent:event.get()];
> +    [contentView _mouseGestureRecognizerChanged:gesture];
> +    [touch setTapCount:1];
> +    [event _setButtonMask:UIEventButtonMaskSecondary];
> +    [gesture touchesBegan:touchSet.get() withEvent:event.get()];
> +    [contentView _mouseGestureRecognizerChanged:gesture];
> +    [gesture touchesEnded:touchSet.get() withEvent:event.get()];
> +    [contentView _mouseGestureRecognizerChanged:gesture];

Very exciting!

Not for this patch, but this seems good to one day unify under the existing macOS click simulation helpers in TestWKWebView.

[Tim Horton]

Created attachment 389078 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 389078 [details]
Patch

Clearing flags on attachment: 389078

Committed r255322: <https://trac.webkit.org/changeset/255322>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Tim Horton]

Reopening to attach new patch.

[Tim Horton]

Created attachment 389103 [details]
Patch

[Tim Horton]

Whoops