Bug 206861 – [LFC][IFC] Decouple Display::LineBox and Layout::LineBoxBuilder

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

ssia

[Radar WebKit Bug Importer]

<rdar://problem/58945284>

[zalan]

Created attachment 388964 [details]
Patch

[zalan]

Created attachment 388991 [details]
Patch

[Antti Koivisto]

Comment on attachment 388991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388991&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:544
> +    inlineContent.lineBoxes.append(Display::LineBox { lineBox.logicalRect(), lineBox.scrollableOverflow(), lineInkOverflow, { baseline.ascent(), baseline.descent() }, lineBox.baselineOffset(), lineBox.isConsideredEmpty() });

Could have some sort of helper for the conversion.

Type name Display::LineBox is probably not needed.

> Source/WebCore/layout/inlineformatting/InlineLineBox.h:36
> +namespace Layout {
> +
> +class LineBox {

Could this be like LineBoxBuilder or something?

[zalan]

(In reply to Antti Koivisto from comment #4)
> Comment on attachment 388991 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388991&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:544
> > +    inlineContent.lineBoxes.append(Display::LineBox { lineBox.logicalRect(), lineBox.scrollableOverflow(), lineInkOverflow, { baseline.ascent(), baseline.descent() }, lineBox.baselineOffset(), lineBox.isConsideredEmpty() });
> 
> Could have some sort of helper for the conversion.
This will eventually turn into a logical -> physical conversion (horizontal flip/vertical transform). I am not yet sure the exact setup for this so I prefer to not do it in this patch.  

> 
> Type name Display::LineBox is probably not needed.
> 
> > Source/WebCore/layout/inlineformatting/InlineLineBox.h:36
> > +namespace Layout {
> > +
> > +class LineBox {
> 
> Could this be like LineBoxBuilder or something?
Sure.

[zalan]

Created attachment 389007 [details]
Patch

[zalan]

Created attachment 389009 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 389009 [details]
Patch

Clearing flags on attachment: 389009

Committed r255257: <https://trac.webkit.org/changeset/255257>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.