Bug 206859 - [WinCairo][curl] ASSERTION FAILED: sessionID != PAL::SessionID::defaultSessionID() in WebKit::CacheStorage::Engine::destroyEngine since r255137
Summary: [WinCairo][curl] ASSERTION FAILED: sessionID != PAL::SessionID::defaultSessio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-27 19:36 PST by Fujii Hironori
Modified: 2020-01-27 21:13 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.93 KB, patch)
2020-01-27 19:46 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2020-01-27 19:36:00 PST 
[WinCairo][curl] ASSERTION FAILED: sessionID != PAL::SessionID::defaultSessionID() in WebKit::CacheStorage::Engine::destroyEngine since r255137

The fix of r255137 isn't enough,
WinCairo debug WK2 is still failing an assertion while shutdown.

>   ASSERTION FAILED: sessionID != PAL::SessionID::defaultSessionID()
>   C:\jenkins_slave\WinCairo-master\Source\WebKit\NetworkProcess/cache/CacheStorageEngine.cpp(101) : WebKit::CacheStorage::Engine::destroyEngine
>   1   00007FFA0D2D1F9A WTFCrash
>   2   00007FF9D05601F1 WTFCrashWithInfo
>   3   00007FF9D49DBA59 WebKit::CacheStorage::Engine::destroyEngine
>   4   00007FF9D482DC7F WebKit::NetworkProcess::destroySession
>   5   00007FF9D428D100 WebKit::NetworkProcessMainCurl::platformFinalize
>   6   00007FF9D428C9BA WebKit::AuxiliaryProcessMain<WebKit::NetworkProcess,WebKit::NetworkProcessMainCurl>
>   7   00007FF9D428C79F WebKit::NetworkProcessMain
>   8   00007FF69F4D1030 main
>   9   00007FF69F4D1270 __scrt_common_main_seh
>   10  00007FFA40517BD4 BaseThreadInitThunk
>   11  00007FFA4086CED1 RtlUserThreadStart
Comment 1 Fujii Hironori 2020-01-27 19:46:51 PST 
Created attachment 388960 [details]
Patch
Comment 2 Fujii Hironori 2020-01-27 21:12:52 PST 
Comment on attachment 388960 [details]
Patch

Clearing flags on attachment: 388960

Committed r255225: <https://trac.webkit.org/changeset/255225>
Comment 3 Fujii Hironori 2020-01-27 21:12:55 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-01-27 21:13:16 PST 
<rdar://problem/58945248>