Bug 206824 – Blob media loading does not work with GPUProcess

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[youenn fablet]

Blob media loading does not work with GPUProcess

[Radar WebKit Bug Importer]

<rdar://problem/58917596>

[youenn fablet]

Created attachment 388981 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 388981 [details]
Patch

Clearing flags on attachment: 388981

Committed r255237: <https://trac.webkit.org/changeset/255237>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 206889

[youenn fablet]

Breaking win build apparently:
https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/10234

C:\cygwin\worker\win10-release\build\Source\WebCore\platform\graphics\avfoundation\cf\InbandTextTrackPrivateLegacyAVCF.cpp(47,32): error C2664: 'WebCore::InbandTextTrackPrivateAVF::InbandTextTrackPrivateAVF(const WebCore::InbandTextTrackPrivateAVF &)': cannot convert argument 1 from 'WebCore::MediaPlayerPrivateAVFoundationCF *' to 'const WebCore::InbandTextTrackPrivateAVF &' [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\worker\win10-release\build\Source\WebCore\platform\graphics\avfoundation\cf\InbandTextTrackPrivateLegacyAVCF.cpp(49,1): message : Reason: cannot convert from 'WebCore::MediaPlayerPrivateAVFoundationCF *' to 'const WebCore::InbandTextTrackPrivateAVF' [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\worker\win10-release\build\Source\WebCore\platform\graphics\avfoundation\cf\InbandTextTrackPrivateLegacyAVCF.cpp(49,1): message : No constructor could take the source type, or constructor overload resolution was ambiguous [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
  CookieStorageCFNet.cpp
  CredentialStorageCFNet.cpp
  DNSResolveQueueCFNet.cpp
C:\cygwin\worker\win10-release\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.h(113,1): message : see declaration of 'WebCore::InbandTextTrackPrivateAVF::InbandTextTrackPrivateAVF' (compiling source file C:\cygwin\worker\win10-release\build\Source\WebCore\platform\graphics\avfoundation\cf\InbandTextTrackPrivateLegacyAVCF.cpp) [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\worker\win10-release\build\Source\WebCore\page\CaptionUserPreferencesMediaAF.cpp(131,9): error C2065: 'MTEnableCaption2015BehaviorPtrType': undeclared identifier [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\worker\win10-release\build\Source\WebCore\page\CaptionUserPreferencesMediaAF.cpp(131,44): error C2146: syntax error: missing ';' before identifier 'function' [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\worker\win10-release\build\Source\WebCore\page\CaptionUserPreferencesMediaAF.cpp(131,44): error C2065: 'function': undeclared identifier [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\worker\win10-release\build\Source\WebCore\page\CaptionUserPreferencesMediaAF.cpp(131,55): error C3861: 'MTEnableCaption2015BehaviorPtr': identifier not found [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
  FormDataStreamCFNet.cpp
C:\cygwin\worker\win10-release\build\Source\WebCore\page\CaptionUserPreferencesMediaAF.cpp(132,14): error C2065: 'function': undeclared identifier [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
  LoaderRunLoopCF.cpp
  NetworkStorageSessionCFNet.cpp
  NetworkStorageSessionCFNetWin.cpp
  ProtectionSpaceCFNet.cpp
  ProxyServerCFNet.cpp
  ResourceErrorCF.cpp
  ResourceHandleCFNet.cpp
C:\cygwin\worker\win10-release\build\Source\WebCore\page\CaptionUserPreferencesMediaAF.cpp(132,27): error C3861: 'function': identifier not found [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\worker\win10-release\build\Source\WebCore\platform\graphics\avfoundation\cf\MediaPlayerPrivateAVFoundationCF.cpp(1531,48): error C2065: 'AVCFURLAssetInheritURIQueryComponentFromReferencingURIKey': undeclared identifier [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
  ResourceHandleCFURLConnectionDelegate.cpp

[youenn fablet]

EWS win bot is fine and the files I modified in this patch are not compiled by Windows so this seems weird it causes a build issue.

[youenn fablet]

Bot was still failing to compile after the rollout for a few versions and then went green with https://trac.webkit.org/changeset/255258/webkit which is just a test expectation change.

https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/10237 for instance is failing with the same build errors.

Let's try relanding it and see what bots think.

[youenn fablet]

Created attachment 389114 [details]
Patch for relanding

[WebKit Commit Bot]

Comment on attachment 389114 [details]
Patch for relanding

Clearing flags on attachment: 389114

Committed r255347: <https://trac.webkit.org/changeset/255347>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.