Bug 206819 - [Web Animations] Update all DocumentTimeline objects when updating animations
Summary: [Web Animations] Update all DocumentTimeline objects when updating animations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-26 23:49 PST by Antoine Quint
Modified: 2020-01-27 04:02 PST (History)
9 users (show)

See Also:

Attachments
Patch (7.14 KB, patch)
2020-01-26 23:52 PST, Antoine Quint 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2020-01-26 23:49:09 PST 
[Web Animations] Update all DocumentTimeline objects when updating animations
Comment 1 Antoine Quint 2020-01-26 23:52:02 PST 
Created attachment 388835 [details]
Patch
Comment 2 Antti Koivisto 2020-01-27 02:41:32 PST 
Comment on attachment 388835 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388835&action=review

> Source/WebCore/dom/Document.h:2042
> +    Vector<WeakPtr<DocumentTimeline>> m_timelines;

You might want to use WeakHashSet instead if ordering doesn't matter.
Comment 3 Antoine Quint 2020-01-27 04:01:31 PST 
Committed r255141: <https://trac.webkit.org/changeset/255141>
Comment 4 Radar WebKit Bug Importer 2020-01-27 04:02:18 PST 
<rdar://problem/58914325>