Bug 206813 - [LFC][IFC] Display::LineBox has one type of geometry only.
Summary: [LFC][IFC] Display::LineBox has one type of geometry only.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks: LFC
  Show dependency tree / graph
 
Reported: 2020-01-26 17:41 PST by zalan
Modified: 2020-08-03 09:40 PDT (History)
4 users (show)

See Also:

Attachments
Patch (38.58 KB, patch)
2020-01-26 17:46 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-01-26 17:41:52 PST 
LineBox can either be logical or physical.
Comment 1 zalan 2020-01-26 17:46:45 PST 
Created attachment 388819 [details]
Patch
Comment 2 Antti Koivisto 2020-01-27 07:20:13 PST 
Comment on attachment 388819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388819&action=review

> Source/WebCore/ChangeLog:8
> +        It can either represent a logical line box (during layout) or a physical one (during paint/hittest).

This doesn't feel right. Shouldn't we have separate classes for these cases?
Comment 3 zalan 2020-01-27 09:01:16 PST 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 388819 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388819&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        It can either represent a logical line box (during layout) or a physical one (during paint/hittest).
> 
> This doesn't feel right. Shouldn't we have separate classes for these cases?
Yes, that would be cleaner and more inline with what we do with runs. It also implies that we should do something similar with Display::InlineRect/Rect too.