Bug 206807 - [ews] Status bubble hover over message in case of success should indicate whether it built the patch or run tests
Summary: [ews] Status bubble hover over message in case of success should indicate whe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-26 06:24 PST by Aakash Jain
Modified: 2020-01-27 17:49 PST (History)
7 users (show)

See Also:


Attachments
Patch (2.65 KB, patch)
2020-01-26 06:26 PST, Aakash Jain
no flags Details | Formatted Diff | Diff
Screenshot of hover over messages (782.28 KB, image/png)
2020-01-26 06:36 PST, Aakash Jain
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-01-26 06:24:18 PST
Currently for every green status bubble the hover over message is generic and simply says: "Pass". This doesn't indicate whether the queue built the patch, run the tests, or did both. We should change the generic message to more specific like: 'Built successfully', 'Passed tests' or 'Built successfully and passed tests'.

Note that we already have emojis in the status-bubbles indicating whether the queue is builder or tester or both (added in https://trac.webkit.org/changeset/249483/webkit). However, one user provided feedback that he did not paid attention to the emojis and was confused whether the queue was builder or tester.

This change (hover-over text) would provide additional feedback about the queue being builder or tester or both.
Comment 1 Radar WebKit Bug Importer 2020-01-26 06:24:54 PST
<rdar://problem/58901538>
Comment 2 Aakash Jain 2020-01-26 06:26:54 PST
Created attachment 388801 [details]
Patch
Comment 3 Aakash Jain 2020-01-26 06:36:02 PST
Created attachment 388802 [details]
Screenshot of hover over messages
Comment 4 Jonathan Bedard 2020-01-27 09:53:20 PST
Comment on attachment 388801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388801&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:125
> +                    bubble['details_message'] = 'Pass'

Not convinced this is the best UI for Perl and Python tests, but it's definitely an improvement for webkit queues.
Comment 5 Aakash Jain 2020-01-27 10:28:48 PST
Comment on attachment 388801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388801&action=review

>> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:125
>> +                    bubble['details_message'] = 'Pass'
> 
> Not convinced this is the best UI for Perl and Python tests, but it's definitely an improvement for webkit queues.

This 'else' is just a fallback and wouldn't be hit with any of current queues. Perl and Python tests will also say 'Passed tests'.
Comment 6 Aakash Jain 2020-01-27 11:33:09 PST
Committed r255157: <https://trac.webkit.org/changeset/255157>
Comment 7 Aakash Jain 2020-01-27 17:49:28 PST
Deployed on the production server.