Bug 206807 – [ews] Status bubble hover over message in case of success should indicate whether it built the patch or run tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Currently for every green status bubble the hover over message is generic and simply says: "Pass". This doesn't indicate whether the queue built the patch, run the tests, or did both. We should change the generic message to more specific like: 'Built successfully', 'Passed tests' or 'Built successfully and passed tests'.

Note that we already have emojis in the status-bubbles indicating whether the queue is builder or tester or both (added in https://trac.webkit.org/changeset/249483/webkit). However, one user provided feedback that he did not paid attention to the emojis and was confused whether the queue was builder or tester.

This change (hover-over text) would provide additional feedback about the queue being builder or tester or both.

[Radar WebKit Bug Importer]

<rdar://problem/58901538>

[Aakash Jain]

Created attachment 388801 [details]
Patch

[Aakash Jain]

Created attachment 388802 [details]
Screenshot of hover over messages

[Jonathan Bedard]

Comment on attachment 388801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388801&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:125
> +                    bubble['details_message'] = 'Pass'

Not convinced this is the best UI for Perl and Python tests, but it's definitely an improvement for webkit queues.

[Aakash Jain]

Comment on attachment 388801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388801&action=review

>> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:125
>> +                    bubble['details_message'] = 'Pass'
> 
> Not convinced this is the best UI for Perl and Python tests, but it's definitely an improvement for webkit queues.

This 'else' is just a fallback and wouldn't be hit with any of current queues. Perl and Python tests will also say 'Passed tests'.

[Aakash Jain]

Committed r255157: <https://trac.webkit.org/changeset/255157>

[Aakash Jain]

Deployed on the production server.