Bug 206794 - REGRESSION(2.28): [GTK] WPE implementation of show-option-menu breaks the GTK binding
Summary: REGRESSION(2.28): [GTK] WPE implementation of show-option-menu breaks the GTK...
Status: RESOLVED DUPLICATE of bug 222985
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: GTK4
  Show dependency tree / graph
 
Reported: 2020-01-24 20:38 PST by Michael Catanzaro
Modified: 2022-09-20 14:08 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2020-01-24 20:38:39 PST 
[84/87] Generating ../../WebKit2-4.0.gir
../../../../../../Projects/WebKit/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:2137: Warning: WebKit2: multiple comment blocks documenting 'WebKitWebView::show-option-menu:' identifier (already seen at WebKitWebView.cpp:2101).
../../../../../../Projects/WebKit/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:2137: Warning: WebKit2: incorrect number of parameters in comment block, parameter annotations will be ignored.

The problem is that introspection scanner doesn't respect #if PLATFORM(WPE).

I tried adding #ifndef __GI_SCANNER__ but that didn't work. I think it's going to require adding a platformClassInit() call in order to split the WPE signal registration out into WebKitWebViewWPE.cpp. (But not for GTK, because that would break the introspection.) That might be acceptable if we never care about making the WPE API introspectable.

If we do care about WPE introspection, then I don't know what to suggest.
Comment 1 Carlos Garcia Campos 2020-01-29 03:55:06 PST 
(In reply to Michael Catanzaro from comment #0)
> [84/87] Generating ../../WebKit2-4.0.gir
> ../../../../../../Projects/WebKit/Source/WebKit/UIProcess/API/glib/
> WebKitWebView.cpp:2137: Warning: WebKit2: multiple comment blocks
> documenting 'WebKitWebView::show-option-menu:' identifier (already seen at
> WebKitWebView.cpp:2101).
> ../../../../../../Projects/WebKit/Source/WebKit/UIProcess/API/glib/
> WebKitWebView.cpp:2137: Warning: WebKit2: incorrect number of parameters in
> comment block, parameter annotations will be ignored.
> 
> The problem is that introspection scanner doesn't respect #if PLATFORM(WPE).

Some how it does, the gir generated is correct. The backend property is inside PLATFORM(WPE) ifdef and it's not included in the gir. The same happens in gtk-doc generated html.

> I tried adding #ifndef __GI_SCANNER__ but that didn't work. I think it's
> going to require adding a platformClassInit() call in order to split the WPE
> signal registration out into WebKitWebViewWPE.cpp. (But not for GTK, because
> that would break the introspection.) That might be acceptable if we never
> care about making the WPE API introspectable.
> 
> If we do care about WPE introspection, then I don't know what to suggest.
Comment 2 Michael Catanzaro 2020-01-29 08:01:25 PST 
So... the gi-scanner is warning that it is doing the wrong thing, but nevertheless doing the right thing...?

I don't plan to investigate further, just wanted to report this nasty warning.
Comment 3 Michael Catanzaro 2022-07-06 06:32:41 PDT 
Maybe we can fix this as part of supporting two GTK API versions at the same time. I've set "Blocks: GTK4" so we don't forget.
Comment 4 Michael Catanzaro 2022-09-20 14:08:48 PDT 
Was already fixed via 238659@main. I just forgot.

*** This bug has been marked as a duplicate of bug 222985 ***