Bug 206790 - Fix internal builds
Summary: Fix internal builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-24 18:46 PST by Keith Rollin
Modified: 2020-01-27 13:14 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.95 KB, patch)
2020-01-27 08:23 PST, Keith Rollin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2020-01-24 18:46:44 PST 
TestRunner.cpp in DumpRenderTree includes ExecutableAllocator.h. In some circumstances, this file can include <os/thread_self_restrict.h>, which in turn includes <machine/cpu_capabilities.h>. This latter file does not exist at a standard location, and the build fails due to not being able to find the file. Fix this by adding a path to it to the build command line.
Comment 1 Radar WebKit Bug Importer 2020-01-24 18:46:56 PST 
<rdar://problem/58888951>
Comment 2 Keith Rollin 2020-01-27 08:23:27 PST 
Created attachment 388862 [details]
Patch
Comment 3 Maciej Stachowiak 2020-01-27 10:23:46 PST 
Is there any plausible way these install path changes could have caused the crashes on bots?
Comment 4 Keith Rollin 2020-01-27 10:59:36 PST 
You mean, could it account for the orange and red bubbles I currently see? I don't see how. The change was to DumpRenderTree, which AFAIK isn't run in the wk2 tests.
Comment 5 Maciej Stachowiak 2020-01-27 11:37:19 PST 
Comment on attachment 388862 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2020-01-27 13:14:06 PST 
Comment on attachment 388862 [details]
Patch

Clearing flags on attachment: 388862

Committed r255163: <https://trac.webkit.org/changeset/255163>
Comment 7 WebKit Commit Bot 2020-01-27 13:14:07 PST 
All reviewed patches have been landed.  Closing bug.