RESOLVED FIXED 206790
Fix internal builds 
https://bugs.webkit.org/show_bug.cgi?id=206790
Summary Fix internal builds
Keith Rollin
Reported 2020-01-24 18:46:44 PST
TestRunner.cpp in DumpRenderTree includes ExecutableAllocator.h. In some circumstances, this file can include <os/thread_self_restrict.h>, which in turn includes <machine/cpu_capabilities.h>. This latter file does not exist at a standard location, and the build fails due to not being able to find the file. Fix this by adding a path to it to the build command line.
Attachments
Patch (1.95 KB, patch)
2020-01-27 08:23 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-01-24 18:46:56 PST
<rdar://problem/58888951>
Keith Rollin
Comment 2 2020-01-27 08:23:27 PST
Created attachment 388862 [details] Patch
Maciej Stachowiak
Comment 3 2020-01-27 10:23:46 PST
Is there any plausible way these install path changes could have caused the crashes on bots?
Keith Rollin
Comment 4 2020-01-27 10:59:36 PST
You mean, could it account for the orange and red bubbles I currently see? I don't see how. The change was to DumpRenderTree, which AFAIK isn't run in the wk2 tests.
Maciej Stachowiak
Comment 5 2020-01-27 11:37:19 PST
Comment on attachment 388862 [details] Patch r=me
WebKit Commit Bot
Comment 6 2020-01-27 13:14:06 PST
Comment on attachment 388862 [details] Patch Clearing flags on attachment: 388862 Committed r255163: <https://trac.webkit.org/changeset/255163>
WebKit Commit Bot
Comment 7 2020-01-27 13:14:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.