Bug 206787 - WebCore: Remove iOS 11 macros from RenderThemeIOS.mm
Summary: WebCore: Remove iOS 11 macros from RenderThemeIOS.mm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-24 17:50 PST by Jonathan Bedard
Modified: 2020-01-27 18:08 PST (History)
14 users (show)

See Also:

Attachments
Patch (4.47 KB, patch)
2020-01-24 17:54 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (4.53 KB, patch)
2020-01-27 07:37 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-01-24 17:50:50 PST 
There are a number of platform checks that are implemented as version checks in this file.
Comment 1 Jonathan Bedard 2020-01-24 17:54:05 PST 
Created attachment 388751 [details]
Patch
Comment 2 Darin Adler 2020-01-25 09:40:46 PST 
Comment on attachment 388751 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388751&action=review

> Source/WTF/wtf/PlatformHave.h:571
> +#define HAVE_FONT_STYLE_0 1
> +#define HAVE_FONT_STYLE_4 1

I think "font style 0" is simply too brief to be unambiguous. I think it should be more like SYSTEM_FONT_STYLE_TITLE_0.

> Source/WebCore/rendering/RenderThemeIOS.mm:1269
> +#if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)

Forgot to use HAVE here.

> Source/WebCore/rendering/RenderThemeIOS.mm:1287
> +#if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)

And here.
Comment 3 Jonathan Bedard 2020-01-27 07:37:28 PST 
Created attachment 388857 [details]
Patch
Comment 4 WebKit Commit Bot 2020-01-27 18:07:11 PST 
Comment on attachment 388857 [details]
Patch

Clearing flags on attachment: 388857

Committed r255219: <https://trac.webkit.org/changeset/255219>
Comment 5 WebKit Commit Bot 2020-01-27 18:07:13 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-01-27 18:08:15 PST 
<rdar://problem/58942377>