RESOLVED FIXED 206784
Make ContentWorlds be identified by an ObjectIdentifier instead of a uint64_t 
https://bugs.webkit.org/show_bug.cgi?id=206784
Summary Make ContentWorlds be identified by an ObjectIdentifier instead of a uint64_t
Brady Eidson
Reported 2020-01-24 16:50:38 PST
Make ContentWorlds be identified by an ObjectIdentifier instead of a uin64_t
Attachments
Patch (39.09 KB, patch)
2020-01-24 16:54 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (39.08 KB, patch)
2020-01-24 22:37 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (39.09 KB, patch)
2020-01-24 22:56 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (39.03 KB, patch)
2020-01-25 09:38 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2020-01-24 16:54:38 PST
Created attachment 388743 [details] Patch
Brady Eidson
Comment 2 2020-01-24 22:37:16 PST
Created attachment 388762 [details] Patch
Brady Eidson
Comment 3 2020-01-24 22:56:42 PST
Created attachment 388763 [details] Patch
Brady Eidson
Comment 4 2020-01-25 09:36:34 PST
Failures: WKUserContentController.ScriptMessageHandlerBasicPostIsolatedWorld UserContentWorld.IsolatedWorldUserScript I'd tried to make it so custom worlds do not conflict with the page content world, but certain API use cases still make it possible. Update that definitely takes care of it is coming.
Brady Eidson
Comment 5 2020-01-25 09:38:37 PST
Created attachment 388778 [details] Patch
WebKit Commit Bot
Comment 6 2020-01-25 21:02:41 PST
The commit-queue encountered the following flaky tests while processing attachment 388778 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2020-01-25 21:03:05 PST
The commit-queue encountered the following flaky tests while processing attachment 388778 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2020-01-25 21:43:01 PST
The commit-queue encountered the following flaky tests while processing attachment 388778 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 9 2020-01-25 21:43:34 PST
Comment on attachment 388778 [details] Patch Clearing flags on attachment: 388778 Committed r255127: <https://trac.webkit.org/changeset/255127>
WebKit Commit Bot
Comment 10 2020-01-25 21:43:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.