Bug 206784 - Make ContentWorlds be identified by an ObjectIdentifier instead of a uint64_t
Summary: Make ContentWorlds be identified by an ObjectIdentifier instead of a uint64_t
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-24 16:50 PST by Brady Eidson
Modified: 2020-01-25 21:44 PST (History)
8 users (show)

See Also:

Attachments
Patch (39.09 KB, patch)
2020-01-24 16:54 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (39.08 KB, patch)
2020-01-24 22:37 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (39.09 KB, patch)
2020-01-24 22:56 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (39.03 KB, patch)
2020-01-25 09:38 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2020-01-24 16:50:38 PST 
Make ContentWorlds be identified by an ObjectIdentifier instead of a uin64_t
Comment 1 Brady Eidson 2020-01-24 16:54:38 PST 
Created attachment 388743 [details]
Patch
Comment 2 Brady Eidson 2020-01-24 22:37:16 PST 
Created attachment 388762 [details]
Patch
Comment 3 Brady Eidson 2020-01-24 22:56:42 PST 
Created attachment 388763 [details]
Patch
Comment 4 Brady Eidson 2020-01-25 09:36:34 PST 
Failures:
WKUserContentController.ScriptMessageHandlerBasicPostIsolatedWorld
UserContentWorld.IsolatedWorldUserScript


I'd tried to make it so custom worlds do not conflict with the page content world, but certain API use cases still make it possible.

Update that definitely takes care of it is coming.
Comment 5 Brady Eidson 2020-01-25 09:38:37 PST 
Created attachment 388778 [details]
Patch
Comment 6 WebKit Commit Bot 2020-01-25 21:02:41 PST 
The commit-queue encountered the following flaky tests while processing attachment 388778 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2020-01-25 21:03:05 PST 
The commit-queue encountered the following flaky tests while processing attachment 388778 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2020-01-25 21:43:01 PST 
The commit-queue encountered the following flaky tests while processing attachment 388778 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2020-01-25 21:43:34 PST 
Comment on attachment 388778 [details]
Patch

Clearing flags on attachment: 388778

Committed r255127: <https://trac.webkit.org/changeset/255127>
Comment 10 WebKit Commit Bot 2020-01-25 21:43:35 PST 
All reviewed patches have been landed.  Closing bug.