Bug 206779 - IntlObject's cached strings should be immortal and safe for concurrent access.
Summary: IntlObject's cached strings should be immortal and safe for concurrent access.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-24 16:15 PST by Mark Lam
Modified: 2020-01-28 09:07 PST (History)
14 users (show)

See Also:

Attachments
proposed patch. (8.90 KB, patch)
2020-01-24 16:26 PST, Mark Lam 		ysuzuki: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-01-24 16:15:25 PST 
<rdar://problem/58831763>
Comment 1 Mark Lam 2020-01-24 16:26:48 PST 
Created attachment 388738 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2020-01-24 16:41:34 PST 
Comment on attachment 388738 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2020-01-24 17:38:18 PST 
I fixed the test to only run with the runDefault configuration.

Landed in r255112:<http://trac.webkit.org/r255112>.
Comment 4 Aakash Jain 2020-01-28 05:41:07 PST 
(In reply to Mark Lam from comment #3)
> Landed in r255112:<http://trac.webkit.org/r255112>.
It seems like this introduced a test failure on JSC ARMv7. EWS did indicated the failure. The commit probably fixed the jsc failure, but not the jsc-armv7 failure. 

Tracked in https://bugs.webkit.org/show_bug.cgi?id=206869
Comment 5 Mark Lam 2020-01-28 09:07:23 PST 
(In reply to Aakash Jain from comment #4)
> (In reply to Mark Lam from comment #3)
> > Landed in r255112:<http://trac.webkit.org/r255112>.
> It seems like this introduced a test failure on JSC ARMv7. EWS did indicated
> the failure. The commit probably fixed the jsc failure, but not the
> jsc-armv7 failure. 
> 
> Tracked in https://bugs.webkit.org/show_bug.cgi?id=206869

Already fixed in https://bugs.webkit.org/show_bug.cgi?id=206791.