RESOLVED FIXED 206775
Update EditorState from WebProcess when requesting context menu 
https://bugs.webkit.org/show_bug.cgi?id=206775
Summary Update EditorState from WebProcess when requesting context menu
Alex Christensen
Reported 2020-01-24 15:50:16 PST
Update EditorState from WebProcess when requesting context menu
Attachments
Patch (5.14 KB, patch)
2020-01-24 15:53 PST, Alex Christensen 		wenson_hsieh: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-01-24 15:53:38 PST
Created attachment 388734 [details] Patch
Alex Christensen
Comment 2 2020-01-24 15:53:41 PST
<rdar://problem/56305573>
Wenson Hsieh
Comment 3 2020-01-24 16:02:58 PST
Comment on attachment 388734 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388734&action=review > Source/WebKit/WebProcess/WebPage/WebContextMenu.cpp:-72 > - m_page->send(Messages::WebPageProxy::ShowContextMenu(contextMenuContextData, UserData(WebProcess::singleton().transformObjectsToHandles(userData.get()).get()))); This seems okay, but we should also consider just calling flushPendingEditorStateUpdate() sending WebPageProxy::ShowContextMenu. This would have the advantage of avoiding editor state computation in the state where nothing changed (so m_hasPendingEditorStateUpdate is false).
Alex Christensen
Comment 4 2020-01-24 16:49:30 PST
Even better! http://trac.webkit.org/r255106
Note You need to log in before you can comment on or make changes to this bug.