Bug 206768 – Invalid ranges in character classes should be syntax errors in Unicode patterns only

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Alexey Shvayka]

In ES5, grammar of CharacterRange was ambiguous, resulting in invalid ranges like /[\d-a]/ being allowed.
As of ES2015, invalid ranges are SyntaxError in unicode patterns, yet still allowed in regular ones to avoid breaking the web.

Test case:
  /[a-\d]/u

Expected:
  SyntaxError thrown

Actual:
  RegExp instance

ECMA262: https://tc39.es/ecma262/#sec-patterns-static-semantics-early-errors-annexb
Test262:
  https://test262.report/browse/built-ins/RegExp/unicode_restricted_character_class_escape.js
  test/built-ins/RegExp/property-escapes/character-class-range*.js
  test/language/literals/regexp/u-invalid-non-empty-class-ranges*.js

[Alexey Shvayka]

Created attachment 388721 [details]
Patch

[Darin Adler]

Comment on attachment 388721 [details]
Patch

Seems like we keep saying “unicode” in error messages but it should be “Unicode”. It’s a propert noun not a common one.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 388721 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 388721 [details]
Patch

Clearing flags on attachment: 388721

Committed r255134: <https://trac.webkit.org/changeset/255134>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/58905705>