Bug 20675 - When changing one animation in a list, don't reset other animations
Summary: When changing one animation in a list, don't reset other animations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-05 15:19 PDT by Chris Marrin
Modified: 2008-09-12 14:57 PDT (History)
2 users (show)

See Also:

Attachments
Patch, including LayoutTest file (15.50 KB, patch)
2008-09-05 15:22 PDT, Chris Marrin 		hyatt: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2008-09-05 15:19:35 PDT 
Today you can have two animations running by having two values in the -webkit-animation-name. If you remove one of those names (by changing -webkit-animation-name to have only one of the names) the removed animation will stop, but the remaining one will reset and start over. It should not affect the running animation.
Comment 1 Chris Marrin 2008-09-05 15:22:47 PDT 
Created attachment 23203 [details]
Patch, including LayoutTest file
Comment 2 Dave Hyatt 2008-09-11 15:14:27 PDT 
Comment on attachment 23203 [details]
Patch, including LayoutTest file

r=me
Comment 3 Dean Jackson 2008-09-12 14:57:33 PDT 
	M	LayoutTests/ChangeLog
	A	LayoutTests/animations/change-one-anim-expected.txt
	A	LayoutTests/animations/change-one-anim.html
	M	WebCore/ChangeLog
	M	WebCore/page/animation/AnimationBase.cpp
	M	WebCore/page/animation/AnimationController.cpp
	M	WebCore/page/animation/CompositeAnimation.cpp
	M	WebCore/page/animation/ImplicitAnimation.cpp
	M	WebCore/page/animation/KeyframeAnimation.h
Committed r36356

Required a little bit of merging thanks to a clashing patch by mitz, but i think it is ok.