SSIA. Also, I have a crappy half-working patch which would allow to do “build-webkit --<port> --check --disable-unified-builds” by running the compiler with “-fsyntax-only” — but that will go to a very WIP separate bug :]
Created attachment 388674 [details] Patch
Comment on attachment 388674 [details] Patch Clearing flags on attachment: 388674 Committed r255070: <https://trac.webkit.org/changeset/255070>
All reviewed patches have been landed. Closing bug.
<rdar://problem/58867012>
Comment on attachment 388674 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388674&action=review > Source/WebCore/Modules/cache/DOMCacheEngine.h:52 > +static inline Exception errorToException(Error error) This doesn’t need to be inlined. We should make this a normal function declaration, stop using "static" and "inline" and move the function definition back into a .cpp file.
Comment on attachment 388674 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388674&action=review >> Source/WebCore/Modules/cache/DOMCacheEngine.h:52 >> +static inline Exception errorToException(Error error) > > This doesn’t need to be inlined. We should make this a normal function declaration, stop using "static" and "inline" and move the function definition back into a .cpp file. Tackled this in bug 206815.
(In reply to Darin Adler from comment #6) > Comment on attachment 388674 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388674&action=review > > >> Source/WebCore/Modules/cache/DOMCacheEngine.h:52 > >> +static inline Exception errorToException(Error error) > > > > This doesn’t need to be inlined. We should make this a normal function declaration, stop using "static" and "inline" and move the function definition back into a .cpp file. > > Tackled this in bug 206815. Thanks, Darin!