206721 – Web Inspector: consolidate UIProcess/WebProcess files into Inspector folders

RESOLVED FIXED 206721

Web Inspector: consolidate UIProcess/WebProcess files into Inspector folders

https://bugs.webkit.org/show_bug.cgi?id=206721

Summary Web Inspector: consolidate UIProcess/WebProcess files into Inspector folders

Devin Rousso

Reported 2020-01-23 17:23:05 PST

All of the Web Inspector code should really live in - Source/WebKit/UIProcess/Inspector - Source/WebKit/WebProcess/Inspector rather than be spread around. This will make it easier for future Web Inspector developers to find code related to Web Inspector.

Attachments
Patch (731.62 KB, patch) 2020-01-23 18:39 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (731.63 KB, patch) 2020-01-23 18:42 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (731.65 KB, patch) 2020-01-23 18:43 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (736.48 KB, patch) 2020-01-23 18:54 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (739.66 KB, patch) 2020-01-23 19:03 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (753.37 KB, patch) 2020-01-23 20:24 PST, Devin Rousso	achristensen: review+	Details Formatted Diff Diff
Patch (759.09 KB, patch) 2020-01-23 23:44 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (766.96 KB, patch) 2020-01-26 23:14 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2020-01-23 18:39:30 PST

Created attachment 388635 [details] Patch

Devin Rousso

Comment 2 2020-01-23 18:42:10 PST

Created attachment 388636 [details] Patch

Devin Rousso

Comment 3 2020-01-23 18:43:17 PST

Created attachment 388637 [details] Patch

Devin Rousso

Comment 4 2020-01-23 18:54:38 PST

Created attachment 388640 [details] Patch

Devin Rousso

Comment 5 2020-01-23 19:03:27 PST

Created attachment 388644 [details] Patch

Devin Rousso

Comment 6 2020-01-23 20:24:08 PST

Created attachment 388647 [details] Patch

Devin Rousso

Comment 7 2020-01-23 23:44:46 PST

Created attachment 388658 [details] Patch

Don Olmstead

Comment 8 2020-01-24 09:12:43 PST

Any reason this is a cq? Devin? Socket side seems fine.

Devin Rousso

Comment 9 2020-01-24 10:44:23 PST

(In reply to Don Olmstead from comment #8) > Any reason this is a cq? Devin? I was waiting for EWS to be all green. > Socket side seems fine. Thanks for taking a look! =D

WebKit Commit Bot

Comment 10 2020-01-26 22:29:34 PST Comment hidden (obsolete)

Comment on attachment 388658 [details] Patch Rejecting attachment 388658 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 388658, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: tcher.cpp patching file Source/WebKit/WebProcess/Inspector/WebInspectorFrontendAPIDispatcher.h patching file Source/WebKit/WebProcess/Inspector/WebInspectorInterruptDispatcher.cpp patching file Source/WebKit/WebProcess/Inspector/WebInspectorInterruptDispatcher.h patching file Source/WebKit/WebProcess/Inspector/WebInspectorInterruptDispatcher.messages.in patching file Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp patching file Source/WebKit/WebProcess/Inspector/WebInspectorUI.h patching file Source/WebKit/WebProcess/Inspector/WebInspectorUI.messages.in patching file Source/WebKit/WebProcess/Inspector/WebPageInspectorTarget.cpp patching file Source/WebKit/WebProcess/Inspector/WebPageInspectorTarget.h patching file Source/WebKit/WebProcess/Inspector/WebPageInspectorTargetController.cpp patching file Source/WebKit/WebProcess/Inspector/WebPageInspectorTargetController.h patching file Source/WebKit/WebProcess/Inspector/WebPageInspectorTargetFrontendChannel.cpp patching file Source/WebKit/WebProcess/Inspector/WebPageInspectorTargetFrontendChannel.h patching file Source/WebKit/WebProcess/Inspector/gtk/WebInspectorUIGtk.cpp patching file Source/WebKit/WebProcess/Inspector/mac/WebInspectorUIMac.mm patching file Source/WebKit/WebProcess/Inspector/win/WebInspectorUIWin.cpp patching file Source/WebKit/WebProcess/WebCoreSupport/WebInspectorClient.cpp rm 'Source/WebKit/WebProcess/WebCoreSupport/WebInspectorClient.cpp' patching file Source/WebKit/WebProcess/WebCoreSupport/WebInspectorClient.h rm 'Source/WebKit/WebProcess/WebCoreSupport/WebInspectorClient.h' patching file Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.cpp rm 'Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.cpp' patching file Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.h rm 'Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.h' patching file Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.messages.in rm 'Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.messages.in' patching file Source/WebKit/WebProcess/WebPage/WebInspector.cpp rm 'Source/WebKit/WebProcess/WebPage/WebInspector.cpp' patching file Source/WebKit/WebProcess/WebPage/WebInspector.h rm 'Source/WebKit/WebProcess/WebPage/WebInspector.h' patching file Source/WebKit/WebProcess/WebPage/WebInspector.messages.in rm 'Source/WebKit/WebProcess/WebPage/WebInspector.messages.in' patching file Source/WebKit/WebProcess/WebPage/WebInspectorFrontendAPIDispatcher.cpp rm 'Source/WebKit/WebProcess/WebPage/WebInspectorFrontendAPIDispatcher.cpp' patching file Source/WebKit/WebProcess/WebPage/WebInspectorFrontendAPIDispatcher.h rm 'Source/WebKit/WebProcess/WebPage/WebInspectorFrontendAPIDispatcher.h' patching file Source/WebKit/WebProcess/WebPage/WebInspectorInterruptDispatcher.cpp rm 'Source/WebKit/WebProcess/WebPage/WebInspectorInterruptDispatcher.cpp' patching file Source/WebKit/WebProcess/WebPage/WebInspectorInterruptDispatcher.h rm 'Source/WebKit/WebProcess/WebPage/WebInspectorInterruptDispatcher.h' patching file Source/WebKit/WebProcess/WebPage/WebInspectorInterruptDispatcher.messages.in rm 'Source/WebKit/WebProcess/WebPage/WebInspectorInterruptDispatcher.messages.in' patching file Source/WebKit/WebProcess/WebPage/WebInspectorUI.cpp rm 'Source/WebKit/WebProcess/WebPage/WebInspectorUI.cpp' patching file Source/WebKit/WebProcess/WebPage/WebInspectorUI.h rm 'Source/WebKit/WebProcess/WebPage/WebInspectorUI.h' patching file Source/WebKit/WebProcess/WebPage/WebInspectorUI.messages.in rm 'Source/WebKit/WebProcess/WebPage/WebInspectorUI.messages.in' patching file Source/WebKit/WebProcess/WebPage/WebPageInspectorTarget.cpp rm 'Source/WebKit/WebProcess/WebPage/WebPageInspectorTarget.cpp' patching file Source/WebKit/WebProcess/WebPage/WebPageInspectorTarget.h rm 'Source/WebKit/WebProcess/WebPage/WebPageInspectorTarget.h' patching file Source/WebKit/WebProcess/WebPage/WebPageInspectorTargetController.cpp rm 'Source/WebKit/WebProcess/WebPage/WebPageInspectorTargetController.cpp' patching file Source/WebKit/WebProcess/WebPage/WebPageInspectorTargetController.h rm 'Source/WebKit/WebProcess/WebPage/WebPageInspectorTargetController.h' patching file Source/WebKit/WebProcess/WebPage/WebPageInspectorTargetFrontendChannel.cpp rm 'Source/WebKit/WebProcess/WebPage/WebPageInspectorTargetFrontendChannel.cpp' patching file Source/WebKit/WebProcess/WebPage/WebPageInspectorTargetFrontendChannel.h rm 'Source/WebKit/WebProcess/WebPage/WebPageInspectorTargetFrontendChannel.h' patching file Source/WebKit/WebProcess/WebPage/gtk/WebInspectorUIGtk.cpp rm 'Source/WebKit/WebProcess/WebPage/gtk/WebInspectorUIGtk.cpp' patching file Source/WebKit/WebProcess/WebPage/mac/WebInspectorUIMac.mm rm 'Source/WebKit/WebProcess/WebPage/mac/WebInspectorUIMac.mm' patching file Source/WebKit/WebProcess/WebPage/win/WebInspectorUIWin.cpp rm 'Source/WebKit/WebProcess/WebPage/win/WebInspectorUIWin.cpp' Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/13311960

Devin Rousso

Comment 11 2020-01-26 23:14:35 PST

Created attachment 388831 [details] Patch

WebKit Commit Bot

Comment 12 2020-01-27 17:13:39 PST

Comment on attachment 388831 [details] Patch Clearing flags on attachment: 388831 Committed r255214: <https://trac.webkit.org/changeset/255214>

WebKit Commit Bot

Comment 13 2020-01-27 17:13:41 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 14 2020-01-27 17:14:17 PST

<rdar://problem/58940928>

Devin Rousso

Comment 15 2020-01-28 01:46:54 PST

Unreviewed, speculative gtk build fix: <https://trac.webkit.org/r255231>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Local Build

Hardware All

OS All

Product WebKit

Component Web Inspector

Assignee

Devin Rousso

Reported

2020-01-23 17:23 PST

Modified

2020-01-28 01:46 PST History

CC List

26 users Show

URL

Keywords InRadar

Depends on

Blocks

achristensen
annulen
basuke
bburg
cdumez
cgarcia
chris.reid
commit-queue
dbates
don.olmstead
ews-watchlist
gyuyoung.kim
hi
Hironori.Fujii
inspector-bugzilla-changes
japhet
joepeck
mcatanzaro
mkwst
pnormand
ross.kirsling
ryuan.choi
sergio
timothy
webkit-bug-importer
zan