Bug 206707 - run-webkit-tests: Handle case where device socket make handle invalid
Summary: run-webkit-tests: Handle case where device socket make handle invalid
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-23 15:42 PST by Jonathan Bedard
Modified: 2020-01-24 09:19 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.91 KB, patch)
2020-01-23 16:06 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (1.91 KB, patch)
2020-01-23 16:49 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (1.91 KB, patch)
2020-01-24 08:13 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-01-23 15:42:06 PST 
If the socket connecting to a device closes before the file handle does, run-webkit-tests may raise an exception. We should gracefully handle this exception.

Note that this is Python 3 fallout.
Comment 1 Jonathan Bedard 2020-01-23 16:06:56 PST 
Created attachment 388608 [details]
Patch
Comment 2 Aakash Jain 2020-01-23 16:43:26 PST 
Comment on attachment 388608 [details]
Patch

rs=me
Comment 3 Jonathan Bedard 2020-01-23 16:49:08 PST 
Created attachment 388617 [details]
Patch
Comment 4 WebKit Commit Bot 2020-01-24 07:59:22 PST 
Comment on attachment 388617 [details]
Patch

Rejecting attachment 388617 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 388617, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Traceback (most recent call last):
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch", line 80, in <module>
    main()
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch", line 75, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: https://webkit-queues.webkit.org/results/13311033
Comment 5 Jonathan Bedard 2020-01-24 08:13:42 PST 
Created attachment 388695 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2020-01-24 09:18:34 PST 
Comment on attachment 388695 [details]
Patch for landing

Clearing flags on attachment: 388695

Committed r255075: <https://trac.webkit.org/changeset/255075>
Comment 7 WebKit Commit Bot 2020-01-24 09:18:36 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-01-24 09:19:48 PST 
<rdar://problem/58869757>