Bug 206704 – [Mac wk2 Release] fast/html/marquee-child-wrap.html flaky failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jason Lawrence]

fast/html/marquee-child-wrap.html 

Description:
Test is flaky failing on Mac wk2 release

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fhtml%2Fmarquee-child-wrap.html

Diff:
https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r254996%20(9737)/fast/html/marquee-child-wrap-diff.png

[Radar WebKit Bug Importer]

<rdar://problem/58850010>

[Alexey Proskuryakov]

Looks like a bad test, should be easily fixable by adding a large scrolldelay.

[Truitt Savell]

Created attachment 388873 [details]
Patch

[Jonathan Bedard]

Comment on attachment 388873 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388873&action=review

> LayoutTests/fast/html/marquee-child-wrap.html:2
> +<marquee style="border:2px solid green"><span>Text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text</span> scrolldelay="10">scrolldelay = 10</marquee>

I would expect this to be in the <marquee> tag like so:

<marquee style="border:2px solid green" scrolldelay="10">

[Truitt Savell]

Created attachment 388876 [details]
Patch

[Truitt Savell]

(In reply to Truitt Savell from comment #5)
> Created attachment 388876 [details]
> Patch

(In reply to Jonathan Bedard from comment #4)
> Comment on attachment 388873 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388873&action=review
> 
> > LayoutTests/fast/html/marquee-child-wrap.html:2
> > +<marquee style="border:2px solid green"><span>Text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text</span> scrolldelay="10">scrolldelay = 10</marquee>
> 
> I would expect this to be in the <marquee> tag like so:
> 
> <marquee style="border:2px solid green" scrolldelay="10">

Made this change and upped the delay. Test passed locally.

[Alexey Proskuryakov]

Comment on attachment 388876 [details]
Patch

Why not make it outrageously high, e.g. 10 minutes?

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 388876 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 388876 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 388876 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 388876 [details]
Patch

Clearing flags on attachment: 388876

Committed r255181: <https://trac.webkit.org/changeset/255181>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.