Bug 206700 - Centralize AuxiliaryProcessMainBase implementations
Summary: Centralize AuxiliaryProcessMainBase implementations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-23 13:58 PST by Don Olmstead
Modified: 2020-01-26 21:50 PST (History)
12 users (show)

See Also:

Attachments
WIP Patch (19.34 KB, patch)
2020-01-23 15:26 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
WIP Patch (19.67 KB, patch)
2020-01-23 15:48 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
WIP Patch (19.77 KB, patch)
2020-01-23 15:56 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
WIP Patch (22.89 KB, patch)
2020-01-23 16:10 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (25.52 KB, patch)
2020-01-23 16:45 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-01-23 13:58:44 PST 
Non-Cocoa ports are using AuxiliaryProcessMainBase for their entry points to WebProcess and NetworkProcess. These should be centralized and use a common naming.
Comment 1 Don Olmstead 2020-01-23 15:26:32 PST Comment hidden (obsolete)
Comment 2 Don Olmstead 2020-01-23 15:48:13 PST Comment hidden (obsolete)
Comment 3 Don Olmstead 2020-01-23 15:56:38 PST Comment hidden (obsolete)
Comment 4 Don Olmstead 2020-01-23 16:10:51 PST Comment hidden (obsolete)
Comment 5 Don Olmstead 2020-01-23 16:45:55 PST 
Created attachment 388616 [details]
Patch

Since a lot of stuff is renamed or moved the diff might be a bit weird. Other than that ready to review by Team Igalia!
Comment 6 WebKit Commit Bot 2020-01-24 06:11:30 PST 
Comment on attachment 388616 [details]
Patch

Clearing flags on attachment: 388616

Committed r255067: <https://trac.webkit.org/changeset/255067>
Comment 7 WebKit Commit Bot 2020-01-24 06:11:32 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-01-24 06:12:15 PST 
<rdar://problem/58866155>
Comment 9 Fujii Hironori 2020-01-26 21:50:33 PST 
Comment on attachment 388616 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388616&action=review

> Source/WebKit/NetworkProcess/curl/NetworkProcessMainCurl.cppSource/WebKit/NetworkProcess/win/NetworkProcessMainWin.cpp:40
> +        globalNetworkProcess->destroySession(PAL::SessionID::defaultSessionID());

Filed: Bug 206817 – [WinCairo][curl] ASSERTION FAILED: sessionID != PAL::SessionID::defaultSessionID() in NetworkProcess since r255067