RESOLVED FIXED 20669
WebCore/css/makeprop.pl silently fails if gperf fails 
https://bugs.webkit.org/show_bug.cgi?id=20669
Summary WebCore/css/makeprop.pl silently fails if gperf fails
Evan Martin
Reported 2008-09-05 10:52:32 PDT
If gperf fails (for example, it's not installed), makeprop.pl goes on its merry way, leading to a confusing compiler error elsewhere.
Attachments
trivial patch (713 bytes, patch)
2008-09-05 10:55 PDT, Evan Martin 		no flags
DetailsFormatted DiffDiff
Die if gperf fails. (1.10 KB, patch)
2008-10-01 18:41 PDT, Evan Martin 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Evan Martin
Comment 1 2008-09-05 10:55:54 PDT
Created attachment 23196 [details] trivial patch I am embarrassed for this patch, since it is not even against your tree. If I get a chance I will upload a better one.
Eric Seidel (no email)
Comment 2 2008-09-05 15:43:15 PDT
I expect it should still apply though. We need to get you a copy of the real webkit. :)
Eric Seidel (no email)
Comment 3 2008-09-05 15:48:50 PDT
Needs a ChangeLog too.
Evan Martin
Comment 4 2008-10-01 18:41:08 PDT
Created attachment 24002 [details] Die if gperf fails. WebCore/ChangeLog | 7 +++++++ WebCore/css/makeprop.pl | 2 +- 2 files changed, 8 insertions(+), 1 deletions(-)
Eric Seidel (no email)
Comment 5 2008-10-01 18:47:16 PDT
Comment on attachment 24002 [details] Die if gperf fails. Looks fine.
Eric Seidel (no email)
Comment 6 2008-10-01 18:47:55 PDT
r37178
Note You need to log in before you can comment on or make changes to this bug.