Bug 20669 - WebCore/css/makeprop.pl silently fails if gperf fails
Summary: WebCore/css/makeprop.pl silently fails if gperf fails
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2008-09-05 10:52 PDT by Evan Martin
Modified: 2008-10-01 18:47 PDT (History)
0 users

See Also:

trivial patch (713 bytes, patch)
2008-09-05 10:55 PDT, Evan Martin
no flags Details | Formatted Diff | Diff
Die if gperf fails. (1.10 KB, patch)
2008-10-01 18:41 PDT, Evan Martin
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Martin 2008-09-05 10:52:32 PDT
If gperf fails (for example, it's not installed), makeprop.pl goes on its merry way, leading to a confusing compiler error elsewhere.
Comment 1 Evan Martin 2008-09-05 10:55:54 PDT
Created attachment 23196 [details]
trivial patch

I am embarrassed for this patch, since it is not even against your tree.  If I get a chance I will upload a better one.
Comment 2 Eric Seidel (no email) 2008-09-05 15:43:15 PDT
I expect it should still apply though.  We need to get you a copy of the real webkit. :)
Comment 3 Eric Seidel (no email) 2008-09-05 15:48:50 PDT
Needs a ChangeLog too.
Comment 4 Evan Martin 2008-10-01 18:41:08 PDT
Created attachment 24002 [details]
Die if gperf fails.

 WebCore/ChangeLog       |    7 +++++++
 WebCore/css/makeprop.pl |    2 +-
 2 files changed, 8 insertions(+), 1 deletions(-)
Comment 5 Eric Seidel (no email) 2008-10-01 18:47:16 PDT
Comment on attachment 24002 [details]
Die if gperf fails.

Looks fine.
Comment 6 Eric Seidel (no email) 2008-10-01 18:47:55 PDT