Bug 206683 - [iOS Release and Mac Release] imported/w3c/web-platform-tests/webrtc/RTCDTMFSender-ontonechange.https.html is flaky failing
Summary: [iOS Release and Mac Release] imported/w3c/web-platform-tests/webrtc/RTCDTMFS...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-23 11:13 PST by Jason Lawrence
Modified: 2020-01-27 13:29 PST (History)
7 users (show)

See Also:


Attachments
Patch (2.25 KB, patch)
2020-01-27 01:54 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Lawrence 2020-01-23 11:13:13 PST
imported/w3c/web-platform-tests/webrtc/RTCDTMFSender-ontonechange.https.html

Description: 
This test is flaky failing on iOS release and Mac release

History:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fwebrtc%2FRTCDTMFSender-ontonechange.https.html

Diff:
--- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/webrtc/RTCDTMFSender-ontonechange.https-expected.txt
+++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/webrtc/RTCDTMFSender-ontonechange.https-actual.txt
@@ -1,14 +1,14 @@
 
-PASS insertDTMF() with default duration and intertoneGap should fire tonechange events at the expected time 
-PASS insertDTMF() with explicit duration and intertoneGap should fire tonechange events at the expected time 
-PASS insertDTMF('') should not fire any tonechange event, including for '' tone 
-PASS insertDTMF() with duration less than 40 should be clamped to 40 
-PASS insertDTMF() with interToneGap less than 30 should be clamped to 30 
-PASS insertDTMF with comma should delay next tonechange event for a constant 2000ms 
-PASS insertDTMF() with transceiver stopped in the middle should stop future tonechange events from firing 
-PASS Calling insertDTMF() in the middle of tonechange events should cause future tonechanges to be updated to new tones 
-PASS Calling insertDTMF() multiple times in the middle of tonechange events should cause future tonechanges to be updated the last provided tones 
-PASS Calling insertDTMF('') in the middle of tonechange events should stop future tonechange events from firing 
+FAIL insertDTMF() with default duration and intertoneGap should fire tonechange events at the expected time assert_unreached: Unexpected promise rejection: Waited too long for canInsertDTMF Reached unreachable code
+FAIL insertDTMF() with explicit duration and intertoneGap should fire tonechange events at the expected time assert_unreached: Unexpected promise rejection: Waited too long for canInsertDTMF Reached unreachable code
+FAIL insertDTMF('') should not fire any tonechange event, including for '' tone assert_unreached: Unexpected promise rejection: Waited too long for canInsertDTMF Reached unreachable code
+FAIL insertDTMF() with duration less than 40 should be clamped to 40 assert_unreached: Unexpected promise rejection: Waited too long for canInsertDTMF Reached unreachable code
+FAIL insertDTMF() with interToneGap less than 30 should be clamped to 30 assert_unreached: Unexpected promise rejection: Waited too long for canInsertDTMF Reached unreachable code
+FAIL insertDTMF with comma should delay next tonechange event for a constant 2000ms assert_unreached: Unexpected promise rejection: Waited too long for canInsertDTMF Reached unreachable code
+FAIL insertDTMF() with transceiver stopped in the middle should stop future tonechange events from firing assert_unreached: Unexpected promise rejection: Waited too long for canInsertDTMF Reached unreachable code
+FAIL Calling insertDTMF() in the middle of tonechange events should cause future tonechanges to be updated to new tones assert_unreached: Unexpected promise rejection: Waited too long for canInsertDTMF Reached unreachable code
+FAIL Calling insertDTMF() multiple times in the middle of tonechange events should cause future tonechanges to be updated the last provided tones assert_unreached: Unexpected promise rejection: Waited too long for canInsertDTMF Reached unreachable code
+FAIL Calling insertDTMF('') in the middle of tonechange events should stop future tonechange events from firing assert_unreached: Unexpected promise rejection: Waited too long for canInsertDTMF Reached unreachable code
 FAIL Setting transceiver.currentDirection to recvonly in the middle of tonechange events should stop future tonechange events from firing Cannot insert DTMF
 PASS Tone change event constructor works 
 PASS Tone change event with unexpected name should not crash
Comment 1 Radar WebKit Bug Importer 2020-01-23 11:13:36 PST
<rdar://problem/58841339>
Comment 2 Truitt Savell 2020-01-23 15:44:27 PST
This test appears to have been flaky for a long time, but got significantly more flaky around r253206.
Comment 3 Truitt Savell 2020-01-23 15:45:49 PST
Mac became more flakey around r253600
Comment 4 youenn fablet 2020-01-27 01:54:19 PST
Created attachment 388841 [details]
Patch
Comment 5 youenn fablet 2020-01-27 11:05:28 PST
Will upstream WPT changes separately
Comment 6 WebKit Commit Bot 2020-01-27 12:57:33 PST
The commit-queue encountered the following flaky tests while processing attachment 388841 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2020-01-27 12:57:42 PST
The commit-queue encountered the following flaky tests while processing attachment 388841 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2020-01-27 13:29:28 PST
Comment on attachment 388841 [details]
Patch

Clearing flags on attachment: 388841

Committed r255166: <https://trac.webkit.org/changeset/255166>
Comment 9 WebKit Commit Bot 2020-01-27 13:29:30 PST
All reviewed patches have been landed.  Closing bug.