Bug 206680 – [ macOS ] fast/frames/sandboxed-iframe-navigation-allowed.html is flaky failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jacob Uphoff]

fast/frames/sandboxed-iframe-navigation-allowed.html is flaky failing on Catalina and Mojave wk1

I did not try to reproduce

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fframes%2Fsandboxed-iframe-navigation-allowed.html

Diff:

--- /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/fast/frames/sandboxed-iframe-navigation-allowed-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/fast/frames/sandboxed-iframe-navigation-allowed-actual.txt
@@ -4,7 +4,7 @@
 
 
 PASS (self.sandboxedFrame.frameWithPlugin.document.getElementById('plugin').destroyStream) == undefined is true
-PASS (self.frameWithPlugin.document.getElementById('plugin').destroyStream) != undefined is true
+FAIL (self.frameWithPlugin.document.getElementById('plugin').destroyStream) != undefined should be true. Threw exception TypeError: null is not an object (evaluating 'self.frameWithPlugin.document.getElementById('plugin').destroyStream')
 PASS String(document.getElementById('sandboxedFrameId').sandbox) is "allow-scripts allow-same-origin"
 PASS successfullyParsed is true

[Radar WebKit Bug Importer]

<rdar://problem/58840416>

[Truitt Savell]

This test is a highly intermittent failure. It has failed throughout the visible history.

[Jacob Uphoff]

Created attachment 388906 [details]
Update Test Expectations

[Jacob Uphoff]

Created attachment 388908 [details]
Update Test Expectations

[Truitt Savell]

Comment on attachment 388908 [details]
Update Test Expectations

Clearing flags on attachment: 388908

Committed r255176: <https://trac.webkit.org/changeset/255176>

[Chris Dumez]

Created attachment 393422 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 393422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393422&action=review

> LayoutTests/fast/frames/resources/sandboxed-iframe-navigation-child.html:-6
> -    self.navigated.location.assign("javascript: top.childFrameWasNavigated();");

Isn't the test all about executing this code in a subframe?

[Chris Dumez]

Comment on attachment 393422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393422&action=review

>> LayoutTests/fast/frames/resources/sandboxed-iframe-navigation-child.html:-6
>> -    self.navigated.location.assign("javascript: top.childFrameWasNavigated();");
> 
> Isn't the test all about executing this code in a subframe?

Looking at the test description, I think you are right that this is part of the thing that was tested (should be able to navigate subframe). I will address the flakiness some other way then.

[Chris Dumez]

Created attachment 393487 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 393487 [details]
Patch

Clearing flags on attachment: 393487

Committed r258405: <https://trac.webkit.org/changeset/258405>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.