Bug 206675 – REGRESSION: [Mac wk2] fast/animation/request-animation-frame.html is flaky failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Jacob Uphoff]

fast/animation/request-animation-frame.html is flaky failing on Mojave wk2 starting around commit 254128

I did not try to reproduce

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fanimation%2Frequest-animation-frame.html

Diff:

--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/fast/animation/request-animation-frame-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/fast/animation/request-animation-frame-actual.txt
@@ -3,7 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS callbackInvoked is true
+FAIL callbackInvoked should be true. Was false.
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Truitt Savell]

This looks like it was fixed for a time around 254405 then broke again around 254790

[Radar WebKit Bug Importer]

<rdar://problem/58839955>

[Chris Dumez]

Created attachment 388864 [details]
Patch

[Said Abou-Hallawa]

Comment on attachment 388864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388864&action=review

> LayoutTests/fast/animation/request-animation-frame.html:8
>  <span id="e"></span>
>  <span id="f"></span>

Do we still need these two elements?

[Chris Dumez]

(In reply to Said Abou-Hallawa from comment #4)
> Comment on attachment 388864 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388864&action=review
> 
> > LayoutTests/fast/animation/request-animation-frame.html:8
> >  <span id="e"></span>
> >  <span id="f"></span>
> 
> Do we still need these two elements?

No, will drop' em

[Chris Dumez]

Created attachment 388868 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 388868 [details]
Patch

Clearing flags on attachment: 388868

Committed r255153: <https://trac.webkit.org/changeset/255153>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.