Bug 206670 - OptimizeAssociativeExpressionTrees should reset value owners before running
Summary: OptimizeAssociativeExpressionTrees should reset value owners before running
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-23 09:56 PST by Saam Barati
Modified: 2020-01-23 12:11 PST (History)
14 users (show)

See Also:

Attachments
patch (1.88 KB, patch)
2020-01-23 10:09 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-01-23 09:56:50 PST 
...
Comment 1 Saam Barati 2020-01-23 09:57:21 PST 
<rdar://problem/58535628>
Comment 2 Saam Barati 2020-01-23 10:09:53 PST 
Created attachment 388560 [details]
patch
Comment 3 Robin Morisset 2020-01-23 10:11:37 PST 
Comment on attachment 388560 [details]
patch

r=me
Comment 4 Mark Lam 2020-01-23 11:30:36 PST 
Comment on attachment 388560 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388560&action=review

> Source/JavaScriptCore/ChangeLog:11
> +        assembly, Mark thinks we're crashing on a "currupt" basic block.

/currupt/corrupt/
Comment 5 WebKit Commit Bot 2020-01-23 12:11:04 PST 
The commit-queue encountered the following flaky tests while processing attachment 388560 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2020-01-23 12:11:40 PST 
Comment on attachment 388560 [details]
patch

Clearing flags on attachment: 388560

Committed r254996: <https://trac.webkit.org/changeset/254996>
Comment 7 WebKit Commit Bot 2020-01-23 12:11:41 PST 
All reviewed patches have been landed.  Closing bug.