fast/forms/interactive-validation-remove-node-in-handler.html Description: This test is timing out. It looks like this regressed around 254700. I have not tried to reproduce this. History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fforms%2Finteractive-validation-remove-node-in-handler.html Diff: --- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/fast/forms/interactive-validation-remove-node-in-handler-expected.txt +++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/fast/forms/interactive-validation-remove-node-in-handler-actual.txt @@ -1,8 +1 @@ -Should not crash or have an assertion failure if a node was removed during an "invalid" event dispatching for the node. - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -PASS The form was submitted. -TEST COMPLETE - +TestController::platformResetPreferencesToConsistentValues - Failed to remove presented view controller
<rdar://problem/58837865>
r254700 only affects WK1 so it can’t be it. It’s most certainly https://trac.webkit.org/r254699.
Reproduction: run-webkit-tests --debug --ios-simulator --no-retry fast/forms/interactive-validation-remove-node-in-handler.html
(In reply to Ryosuke Niwa from comment #3) > Reproduction: > run-webkit-tests --debug --ios-simulator --no-retry > fast/forms/interactive-validation-remove-node-in-handler.html Oops, this doesn't work. This does: run-webkit-tests --debug --ios-simulator --no-retry fast/forms/interactive-validation-prevented.html fast/forms/interactive-validation-remove-node-in-handler.html
Created attachment 388756 [details] Fixes interactive-validation-prevented.html
I can definitely dismiss the invalidation bubble manually. I'm not certain why WTR doesn't dismiss these bubbles automatically but there are other tests that manually dismiss invalidation bubbles (fast/forms/interactive-validation-select-crash.html) so do that for now.
(In reply to Ryosuke Niwa from comment #6) > I can definitely dismiss the invalidation bubble manually. I'm not certain > why WTR doesn't dismiss these bubbles automatically but there are other > tests that manually dismiss invalidation bubbles > (fast/forms/interactive-validation-select-crash.html) so do that for now. Apparently Simon deiced that it's better for each test to be cleaning itself up instead of automatically doing it in the test runner so this is expected.
Comment on attachment 388756 [details] Fixes interactive-validation-prevented.html Clearing flags on attachment: 388756 Committed r255115: <https://trac.webkit.org/changeset/255115>
All reviewed patches have been landed. Closing bug.