Bug 206646 - REGRESSION (r254329?): safaridriver regression in "find elements" command
Summary: REGRESSION (r254329?): safaridriver regression in "find elements" command
Status: RESOLVED MOVED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 206827 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-01-23 01:44 PST by Philip Jägenstedt
Modified: 2020-01-27 10:18 PST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Jägenstedt 2020-01-23 01:44:14 PST 
In https://github.com/web-platform-tests/wpt/pull/21369 I have debugged why there are new failures in STP 99 compared to STP 98:
https://github.com/web-platform-tests/wpt/pull/21359#issuecomment-577519963

At the root of it is a "JavaScriptError;Unexpected keyword 'function'. Expected ')' to end a compound expression." which seems to be a failure to execute an internal script called WDFindNodes.js.

In https://wpt.fyi/results/webdriver/tests?diff&filter=ADC&run_id=416830016&run_id=393600011 it looks like this affects many WebDriver endpoints, not just "find elements".
Comment 1 Radar WebKit Bug Importer 2020-01-23 10:09:38 PST 
<rdar://problem/58838680>
Comment 2 BJ Burg 2020-01-23 10:10:47 PST 
Can confirm this is a recent regression, not sure where the fix is yet. I am assuming that the regression point is <https://trac.webkit.org/changeset/254329/webkit> but I have not confirmed. Will keep this updated as I dig further with a debug build.
Comment 3 BJ Burg 2020-01-23 13:50:01 PST 
r254329 indeed caused a problem with how safaridriver inserts sourceURL directives.
A fix has been submitted for review on the safaridriver side.

No fix needed in WebKit, thus no further updates will be provided here. The fix should be included in the next release of Safari Technology Preview.

Unfortunately there is no workaround for this issue in STP99.
Comment 4 BJ Burg 2020-01-27 10:18:02 PST 
*** Bug 206827 has been marked as a duplicate of this bug. ***