Bug 206634 - WTF: Remove old iOS version macros
Summary: WTF: Remove old iOS version macros
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
Keywords: InRadar
Depends on:
Reported: 2020-01-22 17:29 PST by Jonathan Bedard
Modified: 2020-01-24 08:32 PST (History)
12 users (show)

See Also:

Patch (8.59 KB, patch)
2020-01-22 17:34 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (8.60 KB, patch)
2020-01-23 13:20 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-01-22 17:29:19 PST
We have a handful of old iOS 11 and 12 macros in WTF which should be removed.
Comment 1 Radar WebKit Bug Importer 2020-01-22 17:31:02 PST
Comment 2 Jonathan Bedard 2020-01-22 17:34:23 PST
Created attachment 388494 [details]
Comment 3 Darin Adler 2020-01-22 20:22:23 PST
Comment on attachment 388494 [details]

All looks right to me
Comment 4 Jonathan Bedard 2020-01-23 13:20:02 PST
Created attachment 388586 [details]
Comment 5 Jonathan Bedard 2020-01-23 13:21:22 PST
Discovered I had changed 101400 to 101500 for HAVE_CORETEXT_AUTO_OPTICAL_SIZING in a final audit, sending it through EWS one final time before landing.
Comment 6 WebKit Commit Bot 2020-01-24 08:31:56 PST
The commit-queue encountered the following flaky tests while processing attachment 388586 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2020-01-24 08:32:31 PST
Comment on attachment 388586 [details]

Clearing flags on attachment: 388586

Committed r255073: <https://trac.webkit.org/changeset/255073>
Comment 8 WebKit Commit Bot 2020-01-24 08:32:33 PST
All reviewed patches have been landed.  Closing bug.