Bug 206623 - Add an option for logging total phase times
Summary: Add an option for logging total phase times
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-22 15:53 PST by Saam Barati
Modified: 2020-01-22 18:28 PST (History)
14 users (show)

See Also:

Attachments
patch (7.15 KB, patch)
2020-01-22 17:08 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch for landing (7.23 KB, patch)
2020-01-22 17:18 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-01-22 15:53:01 PST 
...
Comment 1 Saam Barati 2020-01-22 17:08:11 PST 
Created attachment 388490 [details]
patch
Comment 2 Robin Morisset 2020-01-22 17:13:22 PST 
Comment on attachment 388490 [details]
patch

r=me
Comment 3 Keith Miller 2020-01-22 17:15:17 PST 
Comment on attachment 388490 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388490&action=review

r=me too with comment.

> Source/JavaScriptCore/runtime/OptionsList.h:167
> +    v(Bool, reportTotalPhaseTimes, false, Normal, nullptr) \

Plox add a string here that explains the difference between this only prints at the end.
Comment 4 Saam Barati 2020-01-22 17:18:34 PST 
Created attachment 388492 [details]
patch for landing
Comment 5 WebKit Commit Bot 2020-01-22 18:27:31 PST 
Comment on attachment 388492 [details]
patch for landing

Clearing flags on attachment: 388492

Committed r254957: <https://trac.webkit.org/changeset/254957>
Comment 6 WebKit Commit Bot 2020-01-22 18:27:32 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-01-22 18:28:13 PST 
<rdar://problem/58820257>