Bug 206622 - Legacy WebKit: Add SPI variant of -setSelectedDOMRange that can perform the selection as if triggered by the user
Summary: Legacy WebKit: Add SPI variant of -setSelectedDOMRange that can perform the s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-22 15:50 PST by Daniel Bates
Modified: 2020-01-22 16:25 PST (History)
2 users (show)

See Also:

Attachments
Patch (5.36 KB, patch)
2020-01-22 16:07 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (5.42 KB, patch)
2020-01-22 16:19 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-01-22 15:50:13 PST 
Add Legacy WebKit SPI that does what Modern WebKit IPI WebPage::selectPositionAtPoint() does.
Comment 1 Daniel Bates 2020-01-22 15:52:05 PST 
This SPI will be used to select the position on the page as if the user had done it.
Comment 2 Daniel Bates 2020-01-22 16:07:24 PST 
Created attachment 388480 [details]
Patch
Comment 3 Daniel Bates 2020-01-22 16:12:18 PST 
Comment on attachment 388480 [details]
Patch

Hold up... I didn't actually add the function I wanted. Haha
Comment 4 Daniel Bates 2020-01-22 16:18:52 PST 
Change of plans... re-purposes this bug to just do what the patch does (though I will post a new patch to update the ChangeLog): add a new SPI variant of -setSelectedDOMRange that takes a bool as to whether the selection is user triggered.
Comment 5 Daniel Bates 2020-01-22 16:19:39 PST 
Created attachment 388482 [details]
Patch
Comment 6 Daniel Bates 2020-01-22 16:23:00 PST 
Thanks for the review, Wenson!
Comment 7 Daniel Bates 2020-01-22 16:24:30 PST 
Comment on attachment 388482 [details]
Patch

Clearing flags on attachment: 388482

Committed r254952: <https://trac.webkit.org/changeset/254952>
Comment 8 Daniel Bates 2020-01-22 16:24:31 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2020-01-22 16:25:13 PST 
<rdar://problem/58815760>