Bug 20662 – debian patches for webkit 1.0.1 (their versioning)

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebKit Misc.

[Luke Kenneth Casson Leighton]

folks, hi,
debian has some strange patches for ARM and other stuff, which i thought best to attach to make sure none of them have been missed.  they're quite small and trivial but highly significant for various architectures.

[Luke Kenneth Casson Leighton]

Created attachment 23189 [details]
debian 1.0.1 downstream patches

[Alexey Proskuryakov]

It's good to have these available for reference, but to get them landed, we'd obviously need to split and categorize the changes, write ChangeLogs etc.

[Jan Alonzo]

(CC'ing Mike Hommey)

Mike: do you know which ones should go upstream and which ones shouldn't?

[Mike Hommey]

(In reply to comment #3)
> (CC'ing Mike Hommey)
> 
> Mike: do you know which ones should go upstream and which ones shouldn't?

Most of it is already in another bug, IIRC. I'll try to find out where it is.
Anyways, I'm currently merging current trunk in and updating the whole thing, so I'll keep you posted.

[Mike Hommey]

So, to take it down:
debian/control is debian specific

WebCore/platform/text/AtomicString.cpp,
WebCore/platform/text/StringHash.h,
JavaScriptCore/wtf/Platform.h,
JavaScriptCore/wtf/ListHashSet.h,
JavaScriptCore/wtf/Vector.h,
JavaScriptCore/wtf/FastMalloc.cpp: These are in bug #19775. While the fix is okay for debian, it is not for webkit without rework

WebCore/platform/graphics/BitmapImage.cpp,
WebCore/platform/graphics/cg/ImageCG.cpp,
WebCore/platform/graphics/cairo/ImageCairo.cpp: Cherry-pick from svn revision 34625.

WebCore/page/gtk/AXObjectCacheAtk.cpp: Fix specific to 1.0.1 release tarball. See bug #19910

[Eric Seidel (no email)]

I noticed this bug this afternoon.  Is there still stuff to do here or should we close this?  It's been a year since the last activity.

[Mike Hommey]

Created attachment 38525 [details]
debian 1.1.13 downstream patch

We still use a part of the patch that was uploaded here. Here are the changes we have against 1.1.13 released yesterday.

[Mike Hommey]

Note this patch is roughly what is in bug 19775.

[Eric Seidel (no email)]

Ok.  That will need to be split up into separate patches and ChangeLogs added of course. :)

[Mike Hommey]

(In reply to comment #9)
> Ok.  That will need to be split up into separate patches and ChangeLogs added
> of course. :)

If I'm not mistaken, the whole patch is to address bug 19775, though some changes in the webkit code made one of the changes affect arm as well.

[Gustavo Noronha (kov)]

This bug is actually obsolete for a while. We no longer carry most of these changes.

*** This bug has been marked as a duplicate of bug 19775 ***