RESOLVED FIXED 206619
[JSC] Bits from Operand should fit in bits reserved in AbstractHeap's Payload 
https://bugs.webkit.org/show_bug.cgi?id=206619
Summary [JSC] Bits from Operand should fit in bits reserved in AbstractHeap's Payload
Yusuke Suzuki
Reported 2020-01-22 15:24:28 PST
[JSC] Bits from Operand should fit in bits reserved in AbstractHeap's Payload
Attachments
Patch (5.56 KB, patch)
2020-01-22 15:29 PST, Yusuke Suzuki 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-01-22 15:29:17 PST
Created attachment 388475 [details] Patch
Yusuke Suzuki
Comment 2 2020-01-22 15:29:20 PST
<rdar://problem/58270260>
Keith Miller
Comment 3 2020-01-22 19:25:31 PST
Comment on attachment 388475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388475&action=review r=me with suggestion. > Source/JavaScriptCore/bytecode/Operands.h:41 > +enum class OperandKind : uint32_t { Argument, Local, Tmp }; // Keep bit-width in sync with Operand::operandKindBits' definition. Nit You can add a `LastOperandKind = Tmp` then compute kindBits from that via getMSBSet.
Yusuke Suzuki
Comment 4 2020-01-23 01:20:59 PST
Comment on attachment 388475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388475&action=review >> Source/JavaScriptCore/bytecode/Operands.h:41 >> +enum class OperandKind : uint32_t { Argument, Local, Tmp }; // Keep bit-width in sync with Operand::operandKindBits' definition. > > Nit You can add a `LastOperandKind = Tmp` then compute kindBits from that via getMSBSet. Sounds nice. Fixed.
Yusuke Suzuki
Comment 5 2020-01-23 01:39:19 PST
Committed r254968: <https://trac.webkit.org/changeset/254968>
Yusuke Suzuki
Comment 6 2020-01-23 04:50:12 PST
Follow-up fix. https://trac.webkit.org/changeset/254975/webkit
Note You need to log in before you can comment on or make changes to this bug.