RESOLVED FIXED 206573
[WinCairo] -webkit-font-smoothing:antialiased makes fonts blurry
https://bugs.webkit.org/show_bug.cgi?id=206573
Summary [WinCairo] -webkit-font-smoothing:antialiased makes fonts blurry
Fujii Hironori
Reported 2020-01-22 00:25:44 PST
[WinCairo] small MS Gothic font with -webkit-font-smoothing:antialiased is blurry r254506 (Bug 54763) added -webkit-font-smoothing support. Since then some texts in Google News of Japanese are rendered blurry. 1. Start WinCairo MiniBrowser 2. Go to https://news.google.com/?hl=ja&gl=JP&ceid=JP%3Aja
Attachments
[Screenshot] Google News (Japan) of WinCairo port (150% display scale factor) (209.77 KB, image/png)
2020-01-22 00:26 PST, Fujii Hironori
no flags
test case (1.66 KB, text/html)
2020-01-22 01:32 PST, Fujii Hironori
no flags
[screenshot] GMail in WinCairo (with -webkit-font-smoothing support, r254899) (191.42 KB, image/png)
2020-01-22 18:25 PST, Fujii Hironori
no flags
[screenshot] GMail in WinCairo (without -webkit-font-smoothing support, r254326) (189.81 KB, image/png)
2020-01-22 18:26 PST, Fujii Hironori
no flags
[screenshot] https://www.apple.com/ in WinCairo (with -webkit-font-smoothing support, r254899) (371.88 KB, image/png)
2020-06-24 00:40 PDT, Fujii Hironori
no flags
Patch (2.44 KB, patch)
2020-06-24 01:31 PDT, Fujii Hironori
achristensen: review+
[screenshot] https://www.apple.com/ in WinCairo with the proposed patch (314.87 KB, image/png)
2020-06-24 01:32 PDT, Fujii Hironori
no flags
Fujii Hironori
Comment 1 2020-01-22 00:26:21 PST
Created attachment 388403 [details] [Screenshot] Google News (Japan) of WinCairo port (150% display scale factor)
Fujii Hironori
Comment 2 2020-01-22 01:32:54 PST
Created attachment 388406 [details] test case
Fujii Hironori
Comment 3 2020-01-22 18:25:45 PST
Created attachment 388502 [details] [screenshot] GMail in WinCairo (with -webkit-font-smoothing support, r254899) I realized GMail also looks blurry even for alphabet.
Fujii Hironori
Comment 4 2020-01-22 18:26:43 PST
Created attachment 388504 [details] [screenshot] GMail in WinCairo (without -webkit-font-smoothing support, r254326) Old WinCairo renders clearly.
Fujii Hironori
Comment 5 2020-01-22 18:32:15 PST
I'm spoofing Safari User-Agent string to use GMail in WinCairo.
Fujii Hironori
Comment 6 2020-06-24 00:40:43 PDT
Created attachment 402626 [details] [screenshot] https://www.apple.com/ in WinCairo (with -webkit-font-smoothing support, r254899)
Fujii Hironori
Comment 7 2020-06-24 01:08:20 PDT
-webkit-font-smoothing:antialiased is mapped to CAIRO_ANTIALIAS_GRAY. And CAIRO_ANTIALIAS_GRAY is mapped to ANTIALIASED_QUALITY. If I changed to use DEFAULT_QUALITY instead of ANTIALIASED_QUALITY by applying the following patch to Cairo, the font looked good. diff --git a/src/win32/cairo-win32-font.c b/src/win32/cairo-win32-font.c index 1f217573b..355192dc0 100644 --- a/src/win32/cairo-win32-font.c +++ b/src/win32/cairo-win32-font.c @@ -347,7 +347,7 @@ _win32_scaled_font_create (LOGFONTW *logfont, case CAIRO_ANTIALIAS_GRAY: case CAIRO_ANTIALIAS_FAST: case CAIRO_ANTIALIAS_GOOD: - f->quality = ANTIALIASED_QUALITY; + f->quality = DEFAULT_QUALITY; break; case CAIRO_ANTIALIAS_SUBPIXEL: case CAIRO_ANTIALIAS_BEST: This issue seems a Windows API issue.
Fujii Hironori
Comment 8 2020-06-24 01:31:49 PDT
Fujii Hironori
Comment 9 2020-06-24 01:32:24 PDT
Created attachment 402628 [details] [screenshot] https://www.apple.com/ in WinCairo with the proposed patch
Alex Christensen
Comment 10 2020-06-24 11:16:30 PDT
Comment on attachment 402627 [details] Patch This seems fine.
Fujii Hironori
Comment 11 2020-06-24 12:58:02 PDT
Radar WebKit Bug Importer
Comment 12 2020-06-24 12:58:17 PDT
Note You need to log in before you can comment on or make changes to this bug.