Bug 206570 – [LFC] Do not create a FormattingContext unless there's content to layout.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

ssia

[Radar WebKit Bug Importer]

<rdar://problem/58785735>

[zalan]

Created attachment 388396 [details]
Patch

[Antti Koivisto]

Comment on attachment 388396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388396&action=review

> Source/WebCore/layout/FormattingContext.cpp:171
>              auto formattingContext = LayoutContext::createFormattingContext(outOfFlowRootContainer, layoutState());
> -            formattingContext->layoutInFlowContent(invalidationState, Geometry::horizontalConstraintsForInFlow(outOfFlowRootDisplayBox), Geometry::verticalConstraintsForInFlow(outOfFlowRootDisplayBox));
> +            if (outOfFlowRootContainer.hasInFlowOrFloatingChild())
> +                formattingContext->layoutInFlowContent(invalidationState, Geometry::horizontalConstraintsForInFlow(outOfFlowRootDisplayBox), Geometry::verticalConstraintsForInFlow(outOfFlowRootDisplayBox));

You are still creating the formatting context.

[zalan]

Comment on attachment 388396 [details]
Patch

Oops

[zalan]

Created attachment 388421 [details]
Patch

[Antti Koivisto]

Comment on attachment 388421 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388421&action=review

> Source/WebCore/ChangeLog:9
> +        We still construct "no-op" FormattingContexts through the computeIntrinsicWidth* codepath.

But why?

[zalan]

Created attachment 388422 [details]
Patch

[zalan]

(In reply to Antti Koivisto from comment #6)
> Comment on attachment 388421 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388421&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        We still construct "no-op" FormattingContexts through the computeIntrinsicWidth* codepath.
> 
> But why?
bug 206581. -and updated the changelog.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 388422 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 388422 [details]
Patch

Clearing flags on attachment: 388422

Committed r254927: <https://trac.webkit.org/changeset/254927>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.