Bug 206561 - Add missing NS_NOESCAPE to CFNetwork SPI
Summary: Add missing NS_NOESCAPE to CFNetwork SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-21 16:20 PST by Alex Christensen
Modified: 2020-01-21 17:30 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.41 KB, patch)
2020-01-21 16:27 PST, Alex Christensen 		joepeck: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-01-21 16:20:19 PST 
Add missing NS_NOESCAPE to CFNetwork SPI
Comment 1 Alex Christensen 2020-01-21 16:27:29 PST 
Created attachment 388369 [details]
Patch
Comment 2 Alex Christensen 2020-01-21 16:27:32 PST 
<rdar://problem/58774422>
Comment 3 Joseph Pecoraro 2020-01-21 17:28:16 PST 
Comment on attachment 388369 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388369&action=review

r=me

> Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:-49
> -#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 120000)
> -@interface NSHTTPCookieStorage (Staging)
> -- (void)_getCookiesForURL:(NSURL *)url mainDocumentURL:(NSURL *)mainDocumentURL partition:(NSString *)partition policyProperties:(NSDictionary*)props completionHandler:(void (^)(NSArray *))completionHandler;
> -- (void)_setCookies:(NSArray *)cookies forURL:(NSURL *)URL mainDocumentURL:(NSURL *)mainDocumentURL policyProperties:(NSDictionary*) props;
> -@end
> -#endif

Nice!
Comment 4 Alex Christensen 2020-01-21 17:30:30 PST 
https://trac.webkit.org/changeset/254895/webkit