Bug 206553 - REGRESSION (r254807): Page Up/Page Down to scroll no longer work
Summary: REGRESSION (r254807): Page Up/Page Down to scroll no longer work
Status: RESOLVED DUPLICATE of bug 206559
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-21 14:01 PST by Simon Fraser (smfr)
Modified: 2020-01-21 15:37 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-01-21 14:01:08 PST 
Can't scroll from the keyboard after r254807.
Comment 1 Radar WebKit Bug Importer 2020-01-21 14:01:36 PST 
<rdar://problem/58772661>
Comment 2 Simon Fraser (smfr) 2020-01-21 15:17:09 PST 
The change in ScrollableArea::setScrollOffsetFromAnimation(), that removed the call to requestScrollPositionUpdate() broke this.

The changelog mentions this was removed to avoid iteration (I think it meant recursion), but through what codepath?
Comment 3 Simon Fraser (smfr) 2020-01-21 15:31:42 PST 
We don't hit any of the newly added calls to requestScrollPositionUpdate() on macOS.
Comment 4 Simon Fraser (smfr) 2020-01-21 15:37:17 PST 

*** This bug has been marked as a duplicate of bug 206559 ***