Bug 206540 - [macOS] Add managed preference to allow synchronous XHR during page dismissal
Summary: [macOS] Add managed preference to allow synchronous XHR during page dismissal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-21 09:41 PST by Chris Dumez
Modified: 2020-01-29 09:57 PST (History)
7 users (show)

See Also:

Attachments
Patch (3.09 KB, patch)
2020-01-21 09:46 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (5.16 KB, patch)
2020-01-21 12:52 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-01-21 09:41:45 PST 
Add managed preference to allow synchronous XHR during page dismissal. This is temporarily needed by some enterprise products until they can update their code.
Comment 1 Chris Dumez 2020-01-21 09:43:11 PST 
<rdar://problem/58644447>
Comment 2 Chris Dumez 2020-01-21 09:46:18 PST 
Created attachment 388311 [details]
Patch
Comment 3 Alex Christensen 2020-01-21 12:41:47 PST 
Comment on attachment 388311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388311&action=review

r=me

> Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:67
> +bool defaultDisallowSyncXHRDuringPageDismissalEnabled()

To avoid double negatives, could we rename this to defaultAllow...
Same with the preference name.

> Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:75
> +    return true;

We should put a FIXME with a radar for iOS.
Comment 4 Chris Dumez 2020-01-21 12:52:34 PST 
Created attachment 388338 [details]
Patch
Comment 5 Chris Dumez 2020-01-21 14:02:44 PST 
Comment on attachment 388338 [details]
Patch

The changed proposed by Alex does not work because WebKitTestRunner turns ON all experimental features.
Comment 6 Chris Dumez 2020-01-21 14:04:19 PST 
Committed r254880: <https://trac.webkit.org/changeset/254880>