DLLLauncherMain print to console instead of opening window on fatal error
Created attachment 388299 [details] Patch
Created attachment 388300 [details] Patch
Created attachment 388303 [details] Patch
Created attachment 388304 [details] Patch
Created attachment 388305 [details] Patch
Comment on attachment 388305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388305&action=review Nice! I hadn't thought of this approach. Can you also apply this change to the other copy of DLLLauncherMain (which we use for all executables other than JSC shell)? https://github.com/WebKit/webkit/blob/master/Tools/win/DLLLauncher/DLLLauncherMain.cpp > Source/JavaScriptCore/shell/DLLLauncherMain.cpp:113 > + fprintf(stderr, "%s %s\n", caption.c_str(), message.c_str()); Our Windows code uses wide-character strings, so let's do this: fwprintf(stderr, L"%s\n%s\n", caption.c_str(), message.c_str()); > Source/JavaScriptCore/shell/DLLLauncherMain.cpp:114 > + exit(1); This shouldn't be necessary; whatever is calling this should just exit with the returned 1.
Comment on attachment 388305 [details] Patch I like this too, but r- to address Ross's comments.
Created attachment 395544 [details] Patch
Committed r259565: <https://trac.webkit.org/changeset/259565> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395544 [details].
<rdar://problem/61330298>