Bug 206518 - Rename JSPromiseFields abstract heap to JSInternalFields.
Summary: Rename JSPromiseFields abstract heap to JSInternalFields.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-20 23:43 PST by Mark Lam
Modified: 2020-01-21 04:33 PST (History)
9 users (show)

See Also:

Attachments
proposed patch. (2.22 KB, patch)
2020-01-20 23:50 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
proposed patch (9.11 KB, patch)
2020-01-21 04:29 PST, Tuomas Karkkainen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-01-20 23:43:22 PST 
This is because it is used for all internal fields, not just the ones in JSPromise.
Comment 1 Radar WebKit Bug Importer 2020-01-20 23:43:45 PST 
<rdar://problem/58751778>
Comment 2 Mark Lam 2020-01-20 23:50:18 PST 
Created attachment 388281 [details]
proposed patch.
Comment 3 Yusuke Suzuki 2020-01-21 00:57:44 PST 
Comment on attachment 388281 [details]
proposed patch.

r=me
Comment 4 WebKit Commit Bot 2020-01-21 01:41:08 PST 
Comment on attachment 388281 [details]
proposed patch.

Clearing flags on attachment: 388281

Committed r254846: <https://trac.webkit.org/changeset/254846>
Comment 5 WebKit Commit Bot 2020-01-21 01:41:10 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Tuomas Karkkainen 2020-01-21 04:29:54 PST 
Created attachment 388289 [details]
proposed patch

- fixes Tools/Scripts/set-webkit-configuration --reset
- addresses some comments
Comment 7 Tuomas Karkkainen 2020-01-21 04:31:04 PST 
(In reply to Tuomas Karkkainen from comment #6)
> Created attachment 388289 [details]
> proposed patch
> 
> - fixes Tools/Scripts/set-webkit-configuration --reset
> - addresses some comments

oops wrong issue.