Bug 206516 - Make RenderingMode and AlphaPremultiplication enum classes and move them to separate headers
Summary: Make RenderingMode and AlphaPremultiplication enum classes and move them to s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 204955 206519
  Show dependency tree / graph
 
Reported: 2020-01-20 20:03 PST by Said Abou-Hallawa
Modified: 2020-01-22 10:15 PST (History)
32 users (show)

See Also:

Attachments
Patch (41.67 KB, patch)
2020-01-20 20:29 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (41.98 KB, patch)
2020-01-20 21:23 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (45.53 KB, patch)
2020-01-20 21:41 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (46.43 KB, patch)
2020-01-20 22:05 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (42.13 KB, patch)
2020-01-21 15:37 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2020-01-20 20:03:40 PST 
RenderingMode and AlphaPremultiplication need to be encoding and decoding when they are sent from the WebProcess to the GPUProcess.
Comment 1 Said Abou-Hallawa 2020-01-20 20:29:47 PST 
Created attachment 388275 [details]
Patch
Comment 2 Said Abou-Hallawa 2020-01-20 21:23:37 PST 
Created attachment 388277 [details]
Patch
Comment 3 Said Abou-Hallawa 2020-01-20 21:41:12 PST 
Created attachment 388278 [details]
Patch
Comment 4 Said Abou-Hallawa 2020-01-20 22:05:52 PST 
Created attachment 388279 [details]
Patch
Comment 5 WebKit Commit Bot 2020-01-21 14:53:11 PST 
Comment on attachment 388279 [details]
Patch

Rejecting attachment 388279 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 388279, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=388279&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=206516&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 388279 from bug 206516.
Fetching: https://bugs.webkit.org/attachment.cgi?id=388279
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 38 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKitLegacy/mac/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/Headers.cmake
patching file Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp
patching file Source/WebCore/WebCore.xcodeproj/project.pbxproj
Hunk #3 succeeded at 25022 (offset 6 lines).
Hunk #4 succeeded at 25199 (offset 6 lines).
Hunk #5 succeeded at 29057 (offset 12 lines).
Hunk #6 FAILED at 31387.
Hunk #7 succeeded at 32033 (offset 13 lines).
Hunk #8 FAILED at 32084.
2 out of 8 hunks FAILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej
patching file Source/WebCore/bindings/js/SerializedScriptValue.cpp
patching file Source/WebCore/css/CSSFilterImageValue.cpp
patching file Source/WebCore/html/CustomPaintCanvas.cpp
patching file Source/WebCore/html/HTMLCanvasElement.cpp
patching file Source/WebCore/html/ImageBitmap.cpp
patching file Source/WebCore/html/OffscreenCanvas.cpp
patching file Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
patching file Source/WebCore/html/canvas/ImageBitmapRenderingContext.cpp
patching file Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
patching file Source/WebCore/html/shadow/MediaControlElements.cpp
patching file Source/WebCore/page/FrameSnapshotting.cpp
patching file Source/WebCore/platform/graphics/AlphaPremultiplication.h
patching file Source/WebCore/platform/graphics/BitmapImage.cpp
patching file Source/WebCore/platform/graphics/GraphicsContext.h
patching file Source/WebCore/platform/graphics/GraphicsTypes.cpp
patching file Source/WebCore/platform/graphics/GraphicsTypes.h
patching file Source/WebCore/platform/graphics/ImageBuffer.h
patching file Source/WebCore/platform/graphics/RenderingMode.h
patching file Source/WebCore/platform/graphics/ShadowBlur.cpp
patching file Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp
patching file Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp
patching file Source/WebCore/platform/graphics/cg/ImageBufferDataCG.h
patching file Source/WebCore/platform/graphics/filters/Filter.h
patching file Source/WebCore/platform/graphics/texmap/BitmapTexture.cpp
patching file Source/WebCore/platform/graphics/win/ImageBufferDirect2D.cpp
patching file Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp
patching file Source/WebCore/rendering/RenderLayer.cpp
Hunk #1 succeeded at 6941 (offset 36 lines).
patching file Source/WebCore/rendering/shapes/Shape.cpp
patching file Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp
patching file Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp
patching file Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp
patching file Source/WebCore/svg/graphics/SVGImage.cpp
patching file Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.mm

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/13309352
Comment 6 Said Abou-Hallawa 2020-01-21 15:37:15 PST 
Created attachment 388362 [details]
Patch
Comment 7 WebKit Commit Bot 2020-01-21 16:26:29 PST 
Comment on attachment 388362 [details]
Patch

Clearing flags on attachment: 388362

Committed r254893: <https://trac.webkit.org/changeset/254893>
Comment 8 WebKit Commit Bot 2020-01-21 16:26:31 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2020-01-21 16:27:15 PST 
<rdar://problem/58778857>
Comment 10 Darin Adler 2020-01-21 17:16:15 PST 
Comment on attachment 388362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388362&action=review

> Source/WebCore/platform/graphics/AlphaPremultiplication.h:37
> +WEBCORE_EXPORT WTF::TextStream& operator<<(WTF::TextStream&, AlphaPremultiplication);

Where is this function defined?
Comment 11 David Kilzer (:ddkilzer) 2020-01-22 05:16:28 PST 
(In reply to WebKit Commit Bot from comment #7)
> Comment on attachment 388362 [details]
> Patch
> 
> Clearing flags on attachment: 388362
> 
> Committed r254893: <https://trac.webkit.org/changeset/254893>

Follow-up build fix for Windows 10 Debug Build:

<https://trac.webkit.org/changeset/254916>

Build failure:

<https://build.webkit.org/builders/Apple%20Win%2010%20Debug%20%28Build%29/builds/9682>
Comment 12 Said Abou-Hallawa 2020-01-22 10:14:05 PST 
(In reply to Darin Adler from comment #10)
> Comment on attachment 388362 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388362&action=review
> 
> > Source/WebCore/platform/graphics/AlphaPremultiplication.h:37
> > +WEBCORE_EXPORT WTF::TextStream& operator<<(WTF::TextStream&, AlphaPremultiplication);
> 
> Where is this function defined?

WebCore/platform/graphics/GraphicsTypes.cpp
Comment 13 Said Abou-Hallawa 2020-01-22 10:15:08 PST 
(In reply to David Kilzer (:ddkilzer) from comment #11)
> (In reply to WebKit Commit Bot from comment #7)
> > Comment on attachment 388362 [details]
> > Patch
> > 
> > Clearing flags on attachment: 388362
> > 
> > Committed r254893: <https://trac.webkit.org/changeset/254893>
> 
> Follow-up build fix for Windows 10 Debug Build:
> 
> <https://trac.webkit.org/changeset/254916>
> 
> Build failure:
> 
> <https://build.webkit.org/builders/Apple%20Win%2010%20Debug%20%28Build%29/
> builds/9682>

Thanks David!