Bug 206500 - Invalid usage of ENABLE() before it's defined in WebCore/layout/integration/LayoutIntegrationBoxTree.cpp
Summary: Invalid usage of ENABLE() before it's defined in WebCore/layout/integration/L...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
Keywords: InRadar
Depends on:
Reported: 2020-01-20 06:48 PST by Adrian Perez
Modified: 2020-01-20 07:44 PST (History)
5 users (show)

See Also:

Patch (1.40 KB, patch)
2020-01-20 06:49 PST, Adrian Perez
no flags Details | Formatted Diff | Diff
Patch for landing (1.44 KB, patch)
2020-01-20 07:09 PST, Adrian Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2020-01-20 06:48:08 PST
The ENABLE() macro is used before "config.h" gets a chance to
be included, which makes the compilation trip. In the usual
arches (at least for the ones tested by EWS bots) unified builds
are masking the issue.
Comment 1 Adrian Perez 2020-01-20 06:49:41 PST
Created attachment 388236 [details]
Comment 2 Carlos Garcia Campos 2020-01-20 06:54:24 PST
Comment on attachment 388236 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=388236&action=review

> Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:30
> -
>  #include "config.h"
> +
> +
>  #include "LayoutIntegrationBoxTree.h"

The header is already guarded, so this should be:

#include "config.h"
#include "LayoutIntegrationBoxTree.h"

Comment 3 Adrian Perez 2020-01-20 07:09:10 PST
Created attachment 388237 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2020-01-20 07:42:39 PST
The commit-queue encountered the following flaky tests while processing attachment 388237 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2020-01-20 07:43:14 PST
Comment on attachment 388237 [details]
Patch for landing

Clearing flags on attachment: 388237

Committed r254825: <https://trac.webkit.org/changeset/254825>
Comment 6 WebKit Commit Bot 2020-01-20 07:43:16 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-01-20 07:44:13 PST