Bug 206495 – [WPE] Add WebKitRectangle, use it for WebKitWebView's SHOW_MENU signal

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

[WPE] Add WebKitRectangle, use it for WebKitWebView's SHOW_MENU signal

[Zan Dobersek]

Created attachment 388227 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Carlos Garcia Campos]

Comment on attachment 388227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388227&action=review

> Source/WebKit/UIProcess/API/wpe/WebKitRectangle.cpp:52
> +    copy->x = rectangle->x;
> +    copy->y = rectangle->y;
> +    copy->width = rectangle->width;
> +    copy->height = rectangle->height;

I think you can do *copy = *rectangle

> Source/WebKit/UIProcess/API/wpe/WebKitRectangle.cpp:71
> +G_DEFINE_BOXED_TYPE(WebKitRectangle, webkit_rectangle, webkit_rectangle_copy, webkit_rectangle_free);

Remove the trailing ;

> Source/WebKit/UIProcess/API/wpe/WebKitRectangle.h:41
> + * Since: 2.24

2.28

> Source/WebKit/UIProcess/API/wpe/WebKitRectangle.h:56
> +

webkit_rectangle_copy and free declaractions are missing here. If we want to leave them as private in favor of g_boxed_copy/free, they should be static in the cpp and undocumented.

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestOptionMenu.cpp:61
> -    static gboolean showOptionMenuCallback(WebKitWebView* webView, WebKitOptionMenu* menu, gpointer*, OptionMenuTest* test)
> +    static gboolean showOptionMenuCallback(WebKitWebView* webView, WebKitOptionMenu* menu, WebKitRectangle* rect, OptionMenuTest* test)

Can we define PlatformRectangle at the top and then use it instead of WebKit/Gdk to remove some #ifdefs?

[Zan Dobersek]

Created attachment 388243 [details]
Patch for landing

[Zan Dobersek]

Comment on attachment 388243 [details]
Patch for landing

Clearing flags on attachment: 388243

Committed r254828: <https://trac.webkit.org/changeset/254828>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/58739327>