Bug 206494 - ScrollableArea.cpp(63): error C2338: ScrollableArea_should_stay_small
Summary: ScrollableArea.cpp(63): error C2338: ScrollableArea_should_stay_small
Status: RESOLVED DUPLICATE of bug 204882
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-20 04:01 PST by Fujii Hironori
Modified: 2020-01-20 22:20 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.57 KB, patch)
2020-01-20 04:10 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2020-01-20 04:01:16 PST 
ScrollableArea.cpp(63): error C2338: ScrollableArea_should_stay_small

AppleWin 32bit can't compile since r254807 (Bug 204882)

> C:\webkit\gc\Source\WebCore\platform/ScrollableArea.cpp(63): error C2338: ScrollableArea_should_stay_small
Comment 1 Fujii Hironori 2020-01-20 04:10:50 PST 
Created attachment 388228 [details]
Patch
Comment 2 cathiechen 2020-01-20 05:06:49 PST 
LGTM, thanks for fixing this!
Comment 3 cathiechen 2020-01-20 07:44:31 PST 
Comment on attachment 388228 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388228&action=review

> Source/WebCore/platform/ScrollableArea.h:412
> +    ScrollBehaviorStatus m_currentScrollBehaviorStatus { ScrollBehaviorStatus::NotInAnimation };

Hmmm, it seems we don't have to expand the size, we can use the bit field in stead, like m_currentScrollType.
Currently, ScrollBehaviorStatus only have two values, so 1 bit seems enough.
Comment 4 David Kilzer (:ddkilzer) 2020-01-20 13:48:46 PST 
This static assertion failure broke some internal Apple builds as well.
Comment 5 Fujii Hironori 2020-01-20 17:42:14 PST 
Cathiechen, it sounds a good idea. I think it should be reverted to fix internal Apple builds as soon as possible. Reverted in r254839.

*** This bug has been marked as a duplicate of bug 204882 ***
Comment 6 cathiechen 2020-01-20 22:20:37 PST 
Thanks, I'll fix this in the new patch.