Bug 206458 - Stop doing synchronous DecidePolicyForNavigationActionSync IPCs for initially empty document loads
Summary: Stop doing synchronous DecidePolicyForNavigationActionSync IPCs for initially...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 206442
  Show dependency tree / graph
 
Reported: 2020-01-17 16:14 PST by Chris Dumez
Modified: 2020-01-22 15:47 PST (History)
8 users (show)

See Also:

Attachments
Patch (2.17 KB, patch)
2020-01-17 16:16 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (6.19 KB, patch)
2020-01-17 16:58 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (6.83 KB, patch)
2020-01-21 16:07 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.24 KB, patch)
2020-01-21 16:33 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.59 KB, patch)
2020-01-21 17:02 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-01-17 16:14:12 PST 
Bypass synchronous DecidePolicyForNavigationAction IPC for initially empty document loads.
Comment 1 Chris Dumez 2020-01-17 16:16:09 PST 
Created attachment 388109 [details]
Patch
Comment 2 Chris Dumez 2020-01-17 16:58:08 PST 
Created attachment 388118 [details]
Patch
Comment 3 Chris Dumez 2020-01-21 16:07:09 PST 
Created attachment 388363 [details]
Patch
Comment 4 Chris Dumez 2020-01-21 16:25:58 PST 
Comment on attachment 388363 [details]
Patch

Brady suggest sending the IPC as async in this case and simply ignore the response. I am looking into this.
Comment 5 Chris Dumez 2020-01-21 16:33:14 PST 
Created attachment 388372 [details]
Patch
Comment 6 Chris Dumez 2020-01-21 17:02:00 PST 
Created attachment 388375 [details]
Patch
Comment 7 WebKit Commit Bot 2020-01-22 11:29:20 PST 
The commit-queue encountered the following flaky tests while processing attachment 388375 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2020-01-22 11:29:53 PST 
Comment on attachment 388375 [details]
Patch

Clearing flags on attachment: 388375

Committed r254930: <https://trac.webkit.org/changeset/254930>
Comment 9 WebKit Commit Bot 2020-01-22 11:29:55 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2020-01-22 15:47:40 PST 
<rdar://problem/58814321>
Comment 11 Radar WebKit Bug Importer 2020-01-22 15:47:43 PST 
<rdar://problem/58814324>