Bug 206456 - Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
Summary: Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-17 15:57 PST by Alex Christensen
Modified: 2020-02-26 20:45 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.81 KB, patch)
2020-01-17 16:00 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (10.31 KB, patch)
2020-02-26 17:33 PST, Alex Christensen 		beidson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-01-17 15:57:50 PST 
Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
Comment 1 Alex Christensen 2020-01-17 16:00:15 PST 
Created attachment 388105 [details]
Patch
Comment 2 youenn fablet 2020-01-30 00:21:22 PST 
Some related API tests seem to fail.
Comment 3 Alex Christensen 2020-02-26 17:33:22 PST 
Created attachment 391820 [details]
Patch
Comment 4 Brady Eidson 2020-02-26 20:32:59 PST 
Comment on attachment 391820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391820&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:346
> -    return _websiteDataStore->sourceApplicationBundleIdentifier();
> +    return nil;

Why leave this here at all?

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:351
>  - (void)_setSourceApplicationBundleIdentifier:(NSString *)identifier
>  {
> -    if (!_websiteDataStore->setSourceApplicationBundleIdentifier(identifier))
> -        [NSException raise:NSGenericException format:@"_setSourceApplicationBundleIdentifier cannot be called after networking has begun"];
>  }

Ditto
Comment 5 Alex Christensen 2020-02-26 20:44:29 PST 
Gone!
http://trac.webkit.org/r257553
Comment 6 Radar WebKit Bug Importer 2020-02-26 20:45:16 PST 
<rdar://problem/59834364>